From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Potential problem in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_pre_process() Date: Sun, 27 Jan 2013 13:18:11 -0800 Message-ID: <20130127211811.GA6680@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Larry Finger , Chaoming Li , "John W. Linville" To: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Return-path: Content-Disposition: inline Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Hi all, while browsing through 'warning: variable =E2=80=98...=E2=80=99 set but= not used' warnings, I found the following code in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_= pre_process(). while (!skb_queue_empty(&rx_queue)) { _skb =3D skb_dequeue(&rx_queue); _rtl_usb_rx_process_agg(hw, skb); ieee80211_rx_irqsafe(hw, skb); } Question: Should the parameter to _rtl_usb_rx_process_agg() and ieee80211_rx_irqsafe() be '_skb' instead of 'skb' ? Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html