* Potential problem in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_pre_process()
@ 2013-01-27 21:18 Guenter Roeck
[not found] ` <20130127211811.GA6680-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2013-01-27 21:18 UTC (permalink / raw)
To: linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA
Cc: Larry Finger, Chaoming Li, John W. Linville
Hi all,
while browsing through 'warning: variable ‘...’ set but not used' warnings, I
found the following code in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_pre_process().
while (!skb_queue_empty(&rx_queue)) {
_skb = skb_dequeue(&rx_queue);
_rtl_usb_rx_process_agg(hw, skb);
ieee80211_rx_irqsafe(hw, skb);
}
Question: Should the parameter to _rtl_usb_rx_process_agg() and
ieee80211_rx_irqsafe() be '_skb' instead of 'skb' ?
Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread[parent not found: <20130127211811.GA6680-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>]
* Re: Potential problem in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_pre_process() [not found] ` <20130127211811.GA6680-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> @ 2013-01-27 22:11 ` Larry Finger 2013-01-27 23:52 ` Guenter Roeck 0 siblings, 1 reply; 3+ messages in thread From: Larry Finger @ 2013-01-27 22:11 UTC (permalink / raw) To: Guenter Roeck Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA, Chaoming Li, John W. Linville On 01/27/2013 03:18 PM, Guenter Roeck wrote: > Hi all, > > while browsing through 'warning: variable ‘...’ set but not used' warnings, I > found the following code in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_pre_process(). > > while (!skb_queue_empty(&rx_queue)) { > _skb = skb_dequeue(&rx_queue); > _rtl_usb_rx_process_agg(hw, skb); > ieee80211_rx_irqsafe(hw, skb); > } > > Question: Should the parameter to _rtl_usb_rx_process_agg() and > ieee80211_rx_irqsafe() be '_skb' instead of 'skb' ? I think you are right and I will submit a patch to fix this. What compiler version reported this? I use "gcc (SUSE Linux) 4.7.2 20130108 [gcc-4_7-branch revision 195012]" and I do not see this warning. Thanks, Larry -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Potential problem in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_pre_process() 2013-01-27 22:11 ` Larry Finger @ 2013-01-27 23:52 ` Guenter Roeck 0 siblings, 0 replies; 3+ messages in thread From: Guenter Roeck @ 2013-01-27 23:52 UTC (permalink / raw) To: Larry Finger; +Cc: linux-wireless, netdev, Chaoming Li, John W. Linville On Sun, Jan 27, 2013 at 04:11:51PM -0600, Larry Finger wrote: > On 01/27/2013 03:18 PM, Guenter Roeck wrote: > >Hi all, > > > >while browsing through 'warning: variable ‘...’ set but not used' warnings, I > >found the following code in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_pre_process(). > > > > while (!skb_queue_empty(&rx_queue)) { > > _skb = skb_dequeue(&rx_queue); > > _rtl_usb_rx_process_agg(hw, skb); > > ieee80211_rx_irqsafe(hw, skb); > > } > > > >Question: Should the parameter to _rtl_usb_rx_process_agg() and > >ieee80211_rx_irqsafe() be '_skb' instead of 'skb' ? > > I think you are right and I will submit a patch to fix this. > > What compiler version reported this? I use "gcc (SUSE Linux) 4.7.2 > 20130108 [gcc-4_7-branch revision 195012]" and I do not see this > warning. > Hi Larry, I use "gcc (Ubuntu/Linaro 4.7.2-2ubuntu1) 4.7.2". You'll see the warning if you build the kernel with W=1. Guenter ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-27 23:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-27 21:18 Potential problem in drivers/net/wireless/rtlwifi/usb.c:_rtl_rx_pre_process() Guenter Roeck
[not found] ` <20130127211811.GA6680-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-01-27 22:11 ` Larry Finger
2013-01-27 23:52 ` Guenter Roeck
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).