From: David Miller <davem@davemloft.net>
To: ebiederm@xmission.com
Cc: netdev@vger.kernel.org, netdev@markandruth.co.uk,
eric.dumazet@gmail.com, therbert@google.com
Subject: Re: [PATCH net-next] ipv6: Fix inet6_csk_bind_conflict so it builds with user namespaces enabled
Date: Tue, 29 Jan 2013 15:20:58 -0500 (EST) [thread overview]
Message-ID: <20130129.152058.125290063772024411.davem@davemloft.net> (raw)
In-Reply-To: <871ud4chgt.fsf@xmission.com>
From: ebiederm@xmission.com (Eric W. Biederman)
Date: Tue, 29 Jan 2013 04:16:18 -0800
>
> When attempting to build linux-next with user namespaces enabled I ran
> into this fun build error.
>
> CC net/ipv6/inet6_connection_sock.o
> .../net/ipv6/inet6_connection_sock.c: In function ‘inet6_csk_bind_conflict’:
> .../net/ipv6/inet6_connection_sock.c:37:12: error: incompatible types when initializing type ‘int’ using
> type ‘kuid_t’
> .../net/ipv6/inet6_connection_sock.c:54:30: error: incompatible type for argument 1 of ‘uid_eq’
> .../include/linux/uidgid.h:48:20: note: expected ‘kuid_t’ but argument is of type ‘int’
> make[3]: *** [net/ipv6/inet6_connection_sock.o] Error 1
> make[2]: *** [net/ipv6] Error 2
> make[2]: *** Waiting for unfinished jobs....
>
> Using kuid_t instead of int to hold the uid fixes this.
>
> Cc: Tom Herbert <therbert@google.com>
> Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Applied, thanks Eric.
prev parent reply other threads:[~2013-01-29 20:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 0:07 [PATCH 4/5 v2] soreuseport: TCP/IPv6 implementation Tom Herbert
2013-01-29 12:16 ` [PATCH net-next] ipv6: Fix inet6_csk_bind_conflict so it builds with user namespaces enabled Eric W. Biederman
2013-01-29 20:20 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129.152058.125290063772024411.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@markandruth.co.uk \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).