* [PATCH 1/3][net-next] gianfar: Optimize struct gfar_priv_tx_q for two cache lines @ 2013-01-29 13:55 Claudiu Manoil 2013-01-29 13:55 ` [PATCH 2/3][net-next] gianfar: Cleanup gfar_parse_group() code Claudiu Manoil 2013-01-29 20:22 ` [PATCH 1/3][net-next] gianfar: Optimize struct gfar_priv_tx_q for two cache lines David Miller 0 siblings, 2 replies; 8+ messages in thread From: Claudiu Manoil @ 2013-01-29 13:55 UTC (permalink / raw) To: netdev; +Cc: David S. Miller Resize and regroup structure members to eliminate memory holes and to pack the structure into 2 cache lines (from 3). tx_ring_size was resized from 4 to 2 bytes and few members were re-grouped in order to eliminate byte holes and achieve compactness. Where possible, few members were grouped according to their usage and access order (i.e. start_xmit vs. clean_tx_ring members), less important members were pushed at the end. Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com> --- drivers/net/ethernet/freescale/gianfar.h | 25 ++++++++++++------------- 1 files changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar.h b/drivers/net/ethernet/freescale/gianfar.h index 91bb2de..045c0d2 100644 --- a/drivers/net/ethernet/freescale/gianfar.h +++ b/drivers/net/ethernet/freescale/gianfar.h @@ -935,26 +935,25 @@ struct tx_q_stats { * @txtime: coalescing value if based on time */ struct gfar_priv_tx_q { + /* cacheline 1 */ spinlock_t txlock __attribute__ ((aligned (SMP_CACHE_BYTES))); - struct sk_buff ** tx_skbuff; - /* Buffer descriptor pointers */ - dma_addr_t tx_bd_dma_base; struct txbd8 *tx_bd_base; struct txbd8 *cur_tx; - struct txbd8 *dirty_tx; + unsigned int num_txbdfree; + unsigned short skb_curtx; + unsigned short tx_ring_size; struct tx_q_stats stats; - struct net_device *dev; struct gfar_priv_grp *grp; - u16 skb_curtx; - u16 skb_dirtytx; - u16 qindex; - unsigned int tx_ring_size; - unsigned int num_txbdfree; + /* cacheline 2 */ + struct net_device *dev; + struct sk_buff **tx_skbuff; + struct txbd8 *dirty_tx; + unsigned short skb_dirtytx; + unsigned short qindex; /* Configuration info for the coalescing features */ - unsigned char txcoalescing; + unsigned int txcoalescing; unsigned long txic; - unsigned short txcount; - unsigned short txtime; + dma_addr_t tx_bd_dma_base; }; /* -- 1.6.6 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/3][net-next] gianfar: Cleanup gfar_parse_group() code 2013-01-29 13:55 [PATCH 1/3][net-next] gianfar: Optimize struct gfar_priv_tx_q for two cache lines Claudiu Manoil @ 2013-01-29 13:55 ` Claudiu Manoil 2013-01-29 13:55 ` [PATCH 3/3][net-next] gianfar: Pack struct gfar_priv_grp into three cachelines Claudiu Manoil 2013-01-29 20:22 ` [PATCH 2/3][net-next] gianfar: Cleanup gfar_parse_group() code David Miller 2013-01-29 20:22 ` [PATCH 1/3][net-next] gianfar: Optimize struct gfar_priv_tx_q for two cache lines David Miller 1 sibling, 2 replies; 8+ messages in thread From: Claudiu Manoil @ 2013-01-29 13:55 UTC (permalink / raw) To: netdev; +Cc: David S. Miller Factor out redundant code (improve readability, source code size). Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com> --- drivers/net/ethernet/freescale/gianfar.c | 34 ++++++++++++++--------------- 1 files changed, 16 insertions(+), 18 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c index e765b9b..fdb8080 100644 --- a/drivers/net/ethernet/freescale/gianfar.c +++ b/drivers/net/ethernet/freescale/gianfar.c @@ -563,40 +563,38 @@ static void enable_napi(struct gfar_private *priv) static int gfar_parse_group(struct device_node *np, struct gfar_private *priv, const char *model) { + struct gfar_priv_grp *grp = &priv->gfargrp[priv->num_grps]; u32 *queue_mask; - priv->gfargrp[priv->num_grps].regs = of_iomap(np, 0); - if (!priv->gfargrp[priv->num_grps].regs) + grp->regs = of_iomap(np, 0); + if (!grp->regs) return -ENOMEM; - priv->gfargrp[priv->num_grps].interruptTransmit = - irq_of_parse_and_map(np, 0); + grp->interruptTransmit = irq_of_parse_and_map(np, 0); /* If we aren't the FEC we have multiple interrupts */ if (model && strcasecmp(model, "FEC")) { - priv->gfargrp[priv->num_grps].interruptReceive = - irq_of_parse_and_map(np, 1); - priv->gfargrp[priv->num_grps].interruptError = - irq_of_parse_and_map(np,2); - if (priv->gfargrp[priv->num_grps].interruptTransmit == NO_IRQ || - priv->gfargrp[priv->num_grps].interruptReceive == NO_IRQ || - priv->gfargrp[priv->num_grps].interruptError == NO_IRQ) + grp->interruptReceive = irq_of_parse_and_map(np, 1); + grp->interruptError = irq_of_parse_and_map(np, 2); + if (grp->interruptTransmit == NO_IRQ || + grp->interruptReceive == NO_IRQ || + grp->interruptError == NO_IRQ) return -EINVAL; } - priv->gfargrp[priv->num_grps].grp_id = priv->num_grps; - priv->gfargrp[priv->num_grps].priv = priv; - spin_lock_init(&priv->gfargrp[priv->num_grps].grplock); + grp->grp_id = priv->num_grps; + grp->priv = priv; + spin_lock_init(&grp->grplock); if (priv->mode == MQ_MG_MODE) { queue_mask = (u32 *)of_get_property(np, "fsl,rx-bit-map", NULL); - priv->gfargrp[priv->num_grps].rx_bit_map = queue_mask ? + grp->rx_bit_map = queue_mask ? *queue_mask : (DEFAULT_MAPPING >> priv->num_grps); queue_mask = (u32 *)of_get_property(np, "fsl,tx-bit-map", NULL); - priv->gfargrp[priv->num_grps].tx_bit_map = queue_mask ? + grp->tx_bit_map = queue_mask ? *queue_mask : (DEFAULT_MAPPING >> priv->num_grps); } else { - priv->gfargrp[priv->num_grps].rx_bit_map = 0xFF; - priv->gfargrp[priv->num_grps].tx_bit_map = 0xFF; + grp->rx_bit_map = 0xFF; + grp->tx_bit_map = 0xFF; } priv->num_grps++; -- 1.6.6 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/3][net-next] gianfar: Pack struct gfar_priv_grp into three cachelines 2013-01-29 13:55 ` [PATCH 2/3][net-next] gianfar: Cleanup gfar_parse_group() code Claudiu Manoil @ 2013-01-29 13:55 ` Claudiu Manoil 2013-01-29 14:35 ` David Laight 2013-01-29 20:22 ` David Miller 2013-01-29 20:22 ` [PATCH 2/3][net-next] gianfar: Cleanup gfar_parse_group() code David Miller 1 sibling, 2 replies; 8+ messages in thread From: Claudiu Manoil @ 2013-01-29 13:55 UTC (permalink / raw) To: netdev; +Cc: David S. Miller * remove unused members(!): imask, ievent * move space consuming interrupt name strings (int_name_* members) to external structures, unessential for the driver's hot path * keep high priority hot path data within the first 2 cache lines This reduces struct gfar_priv_grp from 6 to 3 cache lines. (Also fixed checkpatch warnings for the old code, in the process.) Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com> --- drivers/net/ethernet/freescale/gianfar.c | 98 ++++++++++++++++++++---------- drivers/net/ethernet/freescale/gianfar.h | 40 +++++++------ 2 files changed, 87 insertions(+), 51 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c index fdb8080..19c54a0 100644 --- a/drivers/net/ethernet/freescale/gianfar.c +++ b/drivers/net/ethernet/freescale/gianfar.c @@ -544,6 +544,19 @@ static void unmap_group_regs(struct gfar_private *priv) iounmap(priv->gfargrp[i].regs); } +static void free_gfar_dev(struct gfar_private *priv) +{ + int i, j; + + for (i = 0; i < priv->num_grps; i++) + for (j = 0; j < GFAR_NUM_IRQS; j++) { + kfree(priv->gfargrp[i].irqinfo[j]); + priv->gfargrp[i].irqinfo[j] = NULL; + } + + free_netdev(priv->ndev); +} + static void disable_napi(struct gfar_private *priv) { int i; @@ -565,20 +578,36 @@ static int gfar_parse_group(struct device_node *np, { struct gfar_priv_grp *grp = &priv->gfargrp[priv->num_grps]; u32 *queue_mask; + int i; + + if (priv->mode == MQ_MG_MODE) { + for (i = 0; i < GFAR_NUM_IRQS; i++) { + grp->irqinfo[i] = kzalloc(sizeof(struct gfar_irqinfo), + GFP_KERNEL); + if (!grp->irqinfo[i]) + return -ENOMEM; + } + } else { + grp->irqinfo[GFAR_TX] = kzalloc(sizeof(struct gfar_irqinfo), + GFP_KERNEL); + if (!grp->irqinfo[GFAR_TX]) + return -ENOMEM; + grp->irqinfo[GFAR_RX] = grp->irqinfo[GFAR_ER] = NULL; + } grp->regs = of_iomap(np, 0); if (!grp->regs) return -ENOMEM; - grp->interruptTransmit = irq_of_parse_and_map(np, 0); + gfar_irq(grp, TX)->irq = irq_of_parse_and_map(np, 0); /* If we aren't the FEC we have multiple interrupts */ if (model && strcasecmp(model, "FEC")) { - grp->interruptReceive = irq_of_parse_and_map(np, 1); - grp->interruptError = irq_of_parse_and_map(np, 2); - if (grp->interruptTransmit == NO_IRQ || - grp->interruptReceive == NO_IRQ || - grp->interruptError == NO_IRQ) + gfar_irq(grp, RX)->irq = irq_of_parse_and_map(np, 1); + gfar_irq(grp, ER)->irq = irq_of_parse_and_map(np, 2); + if (gfar_irq(grp, TX)->irq == NO_IRQ || + gfar_irq(grp, RX)->irq == NO_IRQ || + gfar_irq(grp, ER)->irq == NO_IRQ) return -EINVAL; } @@ -779,7 +808,7 @@ tx_alloc_failed: free_tx_pointers(priv); err_grp_init: unmap_group_regs(priv); - free_netdev(dev); + free_gfar_dev(priv); return err; } @@ -1184,15 +1213,16 @@ static int gfar_probe(struct platform_device *ofdev) /* fill out IRQ number and name fields */ for (i = 0; i < priv->num_grps; i++) { + struct gfar_priv_grp *grp = &priv->gfargrp[i]; if (priv->device_flags & FSL_GIANFAR_DEV_HAS_MULTI_INTR) { - sprintf(priv->gfargrp[i].int_name_tx, "%s%s%c%s", + sprintf(gfar_irq(grp, TX)->name, "%s%s%c%s", dev->name, "_g", '0' + i, "_tx"); - sprintf(priv->gfargrp[i].int_name_rx, "%s%s%c%s", + sprintf(gfar_irq(grp, RX)->name, "%s%s%c%s", dev->name, "_g", '0' + i, "_rx"); - sprintf(priv->gfargrp[i].int_name_er, "%s%s%c%s", + sprintf(gfar_irq(grp, ER)->name, "%s%s%c%s", dev->name, "_g", '0' + i, "_er"); } else - strcpy(priv->gfargrp[i].int_name_tx, dev->name); + strcpy(gfar_irq(grp, TX)->name, dev->name); } /* Initialize the filer table */ @@ -1225,7 +1255,7 @@ register_fail: of_node_put(priv->phy_node); if (priv->tbi_node) of_node_put(priv->tbi_node); - free_netdev(dev); + free_gfar_dev(priv); return err; } @@ -1242,7 +1272,7 @@ static int gfar_remove(struct platform_device *ofdev) unregister_netdev(priv->ndev); unmap_group_regs(priv); - free_netdev(priv->ndev); + free_gfar_dev(priv); return 0; } @@ -1650,9 +1680,9 @@ void gfar_halt(struct net_device *dev) static void free_grp_irqs(struct gfar_priv_grp *grp) { - free_irq(grp->interruptError, grp); - free_irq(grp->interruptTransmit, grp); - free_irq(grp->interruptReceive, grp); + free_irq(gfar_irq(grp, TX)->irq, grp); + free_irq(gfar_irq(grp, RX)->irq, grp); + free_irq(gfar_irq(grp, ER)->irq, grp); } void stop_gfar(struct net_device *dev) @@ -1681,7 +1711,7 @@ void stop_gfar(struct net_device *dev) free_grp_irqs(&priv->gfargrp[i]); } else { for (i = 0; i < priv->num_grps; i++) - free_irq(priv->gfargrp[i].interruptTransmit, + free_irq(gfar_irq(&priv->gfargrp[i], TX)->irq, &priv->gfargrp[i]); } @@ -1856,32 +1886,34 @@ static int register_grp_irqs(struct gfar_priv_grp *grp) /* Install our interrupt handlers for Error, * Transmit, and Receive */ - if ((err = request_irq(grp->interruptError, gfar_error, - 0, grp->int_name_er, grp)) < 0) { + err = request_irq(gfar_irq(grp, ER)->irq, gfar_error, 0, + gfar_irq(grp, ER)->name, grp); + if (err < 0) { netif_err(priv, intr, dev, "Can't get IRQ %d\n", - grp->interruptError); + gfar_irq(grp, ER)->irq); goto err_irq_fail; } - - if ((err = request_irq(grp->interruptTransmit, gfar_transmit, - 0, grp->int_name_tx, grp)) < 0) { + err = request_irq(gfar_irq(grp, TX)->irq, gfar_transmit, 0, + gfar_irq(grp, TX)->name, grp); + if (err < 0) { netif_err(priv, intr, dev, "Can't get IRQ %d\n", - grp->interruptTransmit); + gfar_irq(grp, TX)->irq); goto tx_irq_fail; } - - if ((err = request_irq(grp->interruptReceive, gfar_receive, - 0, grp->int_name_rx, grp)) < 0) { + err = request_irq(gfar_irq(grp, RX)->irq, gfar_receive, 0, + gfar_irq(grp, RX)->name, grp); + if (err < 0) { netif_err(priv, intr, dev, "Can't get IRQ %d\n", - grp->interruptReceive); + gfar_irq(grp, RX)->irq); goto rx_irq_fail; } } else { - if ((err = request_irq(grp->interruptTransmit, gfar_interrupt, - 0, grp->int_name_tx, grp)) < 0) { + err = request_irq(gfar_irq(grp, TX)->irq, gfar_interrupt, 0, + gfar_irq(grp, TX)->name, grp); + if (err < 0) { netif_err(priv, intr, dev, "Can't get IRQ %d\n", - grp->interruptTransmit); + gfar_irq(grp, TX)->irq); goto err_irq_fail; } } @@ -1889,9 +1921,9 @@ static int register_grp_irqs(struct gfar_priv_grp *grp) return 0; rx_irq_fail: - free_irq(grp->interruptTransmit, grp); + free_irq(gfar_irq(grp, TX)->irq, grp); tx_irq_fail: - free_irq(grp->interruptError, grp); + free_irq(gfar_irq(grp, ER)->irq, grp); err_irq_fail: return err; diff --git a/drivers/net/ethernet/freescale/gianfar.h b/drivers/net/ethernet/freescale/gianfar.h index 045c0d2..71793f4 100644 --- a/drivers/net/ethernet/freescale/gianfar.h +++ b/drivers/net/ethernet/freescale/gianfar.h @@ -996,18 +996,25 @@ struct gfar_priv_rx_q { unsigned long rxic; }; +enum gfar_irqinfo_id { + GFAR_TX = 0, + GFAR_RX = 1, + GFAR_ER = 2, + GFAR_NUM_IRQS = 3 +}; + +struct gfar_irqinfo { + unsigned int irq; + char name[GFAR_INT_NAME_MAX]; +}; + /** * struct gfar_priv_grp - per group structure * @napi: the napi poll function * @priv: back pointer to the priv structure * @regs: the ioremapped register space for this group * @grp_id: group id for this group - * @interruptTransmit: The TX interrupt number for this group - * @interruptReceive: The RX interrupt number for this group - * @interruptError: The ERROR interrupt number for this group - * @int_name_tx: tx interrupt name for this group - * @int_name_rx: rx interrupt name for this group - * @int_name_er: er interrupt name for this group + * @irqinfo: TX/RX/ER irq data for this group */ struct gfar_priv_grp { @@ -1016,23 +1023,20 @@ struct gfar_priv_grp { struct gfar_private *priv; struct gfar __iomem *regs; unsigned int grp_id; - unsigned long rx_bit_map; - unsigned long tx_bit_map; - unsigned long num_tx_queues; unsigned long num_rx_queues; + unsigned long rx_bit_map; + /* cacheline 3 */ unsigned int rstat; unsigned int tstat; - unsigned int imask; - unsigned int ievent; - unsigned int interruptTransmit; - unsigned int interruptReceive; - unsigned int interruptError; - - char int_name_tx[GFAR_INT_NAME_MAX]; - char int_name_rx[GFAR_INT_NAME_MAX]; - char int_name_er[GFAR_INT_NAME_MAX]; + unsigned long num_tx_queues; + unsigned long tx_bit_map; + + struct gfar_irqinfo *irqinfo[GFAR_NUM_IRQS]; }; +#define gfar_irq(grp, ID) \ + ((grp)->irqinfo[GFAR_##ID]) + enum gfar_errata { GFAR_ERRATA_74 = 0x01, GFAR_ERRATA_76 = 0x02, -- 1.6.6 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* RE: [PATCH 3/3][net-next] gianfar: Pack struct gfar_priv_grp into three cachelines 2013-01-29 13:55 ` [PATCH 3/3][net-next] gianfar: Pack struct gfar_priv_grp into three cachelines Claudiu Manoil @ 2013-01-29 14:35 ` David Laight 2013-01-29 15:19 ` Claudiu Manoil 2013-01-29 20:22 ` David Miller 1 sibling, 1 reply; 8+ messages in thread From: David Laight @ 2013-01-29 14:35 UTC (permalink / raw) To: Claudiu Manoil, netdev; +Cc: David S. Miller > * remove unused members(!): imask, ievent > * move space consuming interrupt name strings (int_name_* members) to > external structures, unessential for the driver's hot path > * keep high priority hot path data within the first 2 cache lines > > This reduces struct gfar_priv_grp from 6 to 3 cache lines. Does it really matter where the message texts are allocated? Provided they aren't intermixed with the 'hot' data. Allocating them separately just seems over complicated. David ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3][net-next] gianfar: Pack struct gfar_priv_grp into three cachelines 2013-01-29 14:35 ` David Laight @ 2013-01-29 15:19 ` Claudiu Manoil 0 siblings, 0 replies; 8+ messages in thread From: Claudiu Manoil @ 2013-01-29 15:19 UTC (permalink / raw) To: David Laight; +Cc: netdev, David S. Miller On 1/29/2013 4:35 PM, David Laight wrote: >> * remove unused members(!): imask, ievent >> * move space consuming interrupt name strings (int_name_* members) to >> external structures, unessential for the driver's hot path >> * keep high priority hot path data within the first 2 cache lines >> >> This reduces struct gfar_priv_grp from 6 to 3 cache lines. > > Does it really matter where the message texts are allocated? > Provided they aren't intermixed with the 'hot' data. > Allocating them separately just seems over complicated. > > David > Hello David, I think that the size of 'struct gfar_priv_grp' matters because we have struct gfar_private { ... struct gfar_priv_grp gfargrp[2]; ... } which in turn will be bloated by an unnecessarily large gfar_priv_grp. gfar_private also contains a fair number of runtime critical members (including gfargrp) and we want those members to fit into as few cachelines as possible too. Also, it would be wasteful to have memory holes inside struct gfar_priv_grp, in this context, and the current patch resolves those memory holes, by compacting this structure to exactly 96 bytes. I don't find this change over complicated, but I'm open to suggestions on where to move those message texts, outside of gfar_priv_grp (or other runtime critical structure). Thanks, Claudiu ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3][net-next] gianfar: Pack struct gfar_priv_grp into three cachelines 2013-01-29 13:55 ` [PATCH 3/3][net-next] gianfar: Pack struct gfar_priv_grp into three cachelines Claudiu Manoil 2013-01-29 14:35 ` David Laight @ 2013-01-29 20:22 ` David Miller 1 sibling, 0 replies; 8+ messages in thread From: David Miller @ 2013-01-29 20:22 UTC (permalink / raw) To: claudiu.manoil; +Cc: netdev From: Claudiu Manoil <claudiu.manoil@freescale.com> Date: Tue, 29 Jan 2013 15:55:12 +0200 > * remove unused members(!): imask, ievent > * move space consuming interrupt name strings (int_name_* members) to > external structures, unessential for the driver's hot path > * keep high priority hot path data within the first 2 cache lines > > This reduces struct gfar_priv_grp from 6 to 3 cache lines. > (Also fixed checkpatch warnings for the old code, in the process.) > > Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com> Applied. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3][net-next] gianfar: Cleanup gfar_parse_group() code 2013-01-29 13:55 ` [PATCH 2/3][net-next] gianfar: Cleanup gfar_parse_group() code Claudiu Manoil 2013-01-29 13:55 ` [PATCH 3/3][net-next] gianfar: Pack struct gfar_priv_grp into three cachelines Claudiu Manoil @ 2013-01-29 20:22 ` David Miller 1 sibling, 0 replies; 8+ messages in thread From: David Miller @ 2013-01-29 20:22 UTC (permalink / raw) To: claudiu.manoil; +Cc: netdev From: Claudiu Manoil <claudiu.manoil@freescale.com> Date: Tue, 29 Jan 2013 15:55:11 +0200 > Factor out redundant code (improve readability, source code size). > > Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com> Applied. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3][net-next] gianfar: Optimize struct gfar_priv_tx_q for two cache lines 2013-01-29 13:55 [PATCH 1/3][net-next] gianfar: Optimize struct gfar_priv_tx_q for two cache lines Claudiu Manoil 2013-01-29 13:55 ` [PATCH 2/3][net-next] gianfar: Cleanup gfar_parse_group() code Claudiu Manoil @ 2013-01-29 20:22 ` David Miller 1 sibling, 0 replies; 8+ messages in thread From: David Miller @ 2013-01-29 20:22 UTC (permalink / raw) To: claudiu.manoil; +Cc: netdev From: Claudiu Manoil <claudiu.manoil@freescale.com> Date: Tue, 29 Jan 2013 15:55:10 +0200 > Resize and regroup structure members to eliminate memory holes and > to pack the structure into 2 cache lines (from 3). > tx_ring_size was resized from 4 to 2 bytes and few members were re-grouped > in order to eliminate byte holes and achieve compactness. > Where possible, few members were grouped according to their usage and access > order (i.e. start_xmit vs. clean_tx_ring members), less important members > were pushed at the end. > > Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com> Applied. ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-01-29 20:22 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-01-29 13:55 [PATCH 1/3][net-next] gianfar: Optimize struct gfar_priv_tx_q for two cache lines Claudiu Manoil 2013-01-29 13:55 ` [PATCH 2/3][net-next] gianfar: Cleanup gfar_parse_group() code Claudiu Manoil 2013-01-29 13:55 ` [PATCH 3/3][net-next] gianfar: Pack struct gfar_priv_grp into three cachelines Claudiu Manoil 2013-01-29 14:35 ` David Laight 2013-01-29 15:19 ` Claudiu Manoil 2013-01-29 20:22 ` David Miller 2013-01-29 20:22 ` [PATCH 2/3][net-next] gianfar: Cleanup gfar_parse_group() code David Miller 2013-01-29 20:22 ` [PATCH 1/3][net-next] gianfar: Optimize struct gfar_priv_tx_q for two cache lines David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).