From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: netdev@vger.kernel.org, pv-drivers@vmware.com, bhutchings@solarflare.com
Subject: Re: [PATCH v3] vmxnet3: set carrier state properly on probe
Date: Tue, 29 Jan 2013 16:29:44 -0500 (EST) [thread overview]
Message-ID: <20130129.162944.795210914241663520.davem@davemloft.net> (raw)
In-Reply-To: <1359494145-28803-1-git-send-email-nhorman@tuxdriver.com>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Tue, 29 Jan 2013 16:15:45 -0500
> vmxnet3 fails to set netif_carrier_off on probe, meaning that when an interface
> is opened the __LINK_STATE_NOCARRIER bit is already cleared, and so
> /sys/class/net/<ifname>/operstate remains in the unknown state. Correct this by
> setting netif_carrier_off on probe, like other drivers do.
>
> Also, while we're at it, lets remove the netif_carrier_ok checks from the
> link_state_update function, as that check is atomically contained within the
> netif_carrier_[on|off] functions anyway
>
> Tested successfully by myself
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Applied, thanks Neil.
prev parent reply other threads:[~2013-01-29 21:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 20:54 [PATCH] vmxnet3: set carrier state properly on probe Neil Horman
2013-01-29 17:54 ` Ben Hutchings
2013-01-29 18:54 ` [Pv-drivers] " Dmitry Torokhov
2013-01-29 19:09 ` Neil Horman
2013-01-29 19:17 ` Ben Hutchings
2013-01-29 19:53 ` Dmitry Torokhov
2013-01-29 18:36 ` [PATCH v2] " Neil Horman
2013-01-29 19:54 ` [Pv-drivers] " Dmitry Torokhov
2013-01-29 20:44 ` David Miller
2013-01-29 21:08 ` Neil Horman
2013-01-29 21:15 ` [PATCH v3] " Neil Horman
2013-01-29 21:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129.162944.795210914241663520.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=pv-drivers@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).