From: David Miller <davem@davemloft.net>
To: vyasevic@redhat.com
Cc: mirq-linux@rere.qmqm.pl, netdev@vger.kernel.org, kaber@trash.net,
shemminger@vyatta.com
Subject: Re: [PATCH net-next] net: disallow drivers with buggy VLAN accel to register_netdevice()
Date: Tue, 29 Jan 2013 22:56:57 -0500 (EST) [thread overview]
Message-ID: <20130129.225657.181728058877634021.davem@davemloft.net> (raw)
In-Reply-To: <510874B9.5000208@redhat.com>
From: Vlad Yasevich <vyasevic@redhat.com>
Date: Tue, 29 Jan 2013 20:17:45 -0500
> On 01/29/2013 08:14 PM, Michał Mirosław wrote:
>> Instead of jumping aroung bugs that are easily fixed just don't let
>> them in:
>> affected drivers should be either fixed or have NETIF_F_HW_VLAN_FILTER
>> removed from advertised features.
>>
>> Quick grep in drivers/net shows two drivers that have
>> NETIF_F_HW_VLAN_FILTER
>> but not ndo_vlan_rx_add/kill_vid(), but those are false-positives
>> (features
>> are commented out).
>>
>> OTOH two drivers have ndo_vlan_rx_add/kill_vid() implemented but don't
>> advertise NETIF_F_HW_VLAN_FILTER. Those are:
>
> I am a bit hesitant to completely disable drivers, but I guess it
> would force people to fix their drivers if this is applied.
I think an improperly implemented driver should be BUG trapped as soon
as possible.
I've applied this patch, thanks.
next prev parent reply other threads:[~2013-01-30 3:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 1:14 [PATCH net-next] net: disallow drivers with buggy VLAN accel to register_netdevice() Michał Mirosław
2013-01-30 1:17 ` Vlad Yasevich
2013-01-30 3:56 ` David Miller [this message]
2013-01-30 13:36 ` Vlad Yasevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129.225657.181728058877634021.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=mirq-linux@rere.qmqm.pl \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).