* [PATCH] Doc: percpu_counter doc code for better readability
@ 2013-01-29 8:31 Jesper Dangaard Brouer
2013-02-04 21:49 ` Tejun Heo
0 siblings, 1 reply; 5+ messages in thread
From: Jesper Dangaard Brouer @ 2013-01-29 8:31 UTC (permalink / raw)
To: joe, linux-kernel, tj; +Cc: Jesper Dangaard Brouer, netdev
Help people reading the percpu_counter code, to notice the ifdef
else statement that seperates CONFIG_SMP.
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
---
include/linux/percpu_counter.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/percpu_counter.h b/include/linux/percpu_counter.h
index b9df9ed..eded1aa 100644
--- a/include/linux/percpu_counter.h
+++ b/include/linux/percpu_counter.h
@@ -83,7 +83,7 @@ static inline int percpu_counter_initialized(struct percpu_counter *fbc)
return (fbc->counters != NULL);
}
-#else
+#else /* No CONFIG_SMP */
struct percpu_counter {
s64 count;
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Doc: percpu_counter doc code for better readability
2013-01-29 8:31 [PATCH] Doc: percpu_counter doc code for better readability Jesper Dangaard Brouer
@ 2013-02-04 21:49 ` Tejun Heo
2013-02-04 22:14 ` [TRIVIAL PATCH V2] " Jesper Dangaard Brouer
0 siblings, 1 reply; 5+ messages in thread
From: Tejun Heo @ 2013-02-04 21:49 UTC (permalink / raw)
To: Jesper Dangaard Brouer; +Cc: joe, linux-kernel, netdev
On Tue, Jan 29, 2013 at 09:31:56AM +0100, Jesper Dangaard Brouer wrote:
> Help people reading the percpu_counter code, to notice the ifdef
> else statement that seperates CONFIG_SMP.
>
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
> ---
>
> include/linux/percpu_counter.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/percpu_counter.h b/include/linux/percpu_counter.h
> index b9df9ed..eded1aa 100644
> --- a/include/linux/percpu_counter.h
> +++ b/include/linux/percpu_counter.h
> @@ -83,7 +83,7 @@ static inline int percpu_counter_initialized(struct percpu_counter *fbc)
> return (fbc->counters != NULL);
> }
>
> -#else
> +#else /* No CONFIG_SMP */
"#else /* !CONFIG_SMP */" would be more conventional. Can you please
change that and repost it w/ my Acked-by and [TRIVIAL] tag added and
Jiri Kosina <trivial@kernel.org> cc'd?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
* [TRIVIAL PATCH V2] Doc: percpu_counter doc code for better readability
2013-02-04 21:49 ` Tejun Heo
@ 2013-02-04 22:14 ` Jesper Dangaard Brouer
2013-02-04 22:10 ` Tejun Heo
0 siblings, 1 reply; 5+ messages in thread
From: Jesper Dangaard Brouer @ 2013-02-04 22:14 UTC (permalink / raw)
To: Jiri Kosina, Tejun Heo, linux-kernel; +Cc: Jesper Dangaard Brouer, netdev, joe
Help people reading the percpu_counter code, to notice the ifdef
else statement that seperates CONFIG_SMP.
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Acked-by: Tejun Heo <tj@kernel.org>
---
include/linux/percpu_counter.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/percpu_counter.h b/include/linux/percpu_counter.h
index b9df9ed..d5dd465 100644
--- a/include/linux/percpu_counter.h
+++ b/include/linux/percpu_counter.h
@@ -83,7 +83,7 @@ static inline int percpu_counter_initialized(struct percpu_counter *fbc)
return (fbc->counters != NULL);
}
-#else
+#else /* !CONFIG_SMP */
struct percpu_counter {
s64 count;
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [TRIVIAL PATCH V2] Doc: percpu_counter doc code for better readability
2013-02-04 22:14 ` [TRIVIAL PATCH V2] " Jesper Dangaard Brouer
@ 2013-02-04 22:10 ` Tejun Heo
2013-02-05 10:54 ` Jiri Kosina
0 siblings, 1 reply; 5+ messages in thread
From: Tejun Heo @ 2013-02-04 22:10 UTC (permalink / raw)
To: Jesper Dangaard Brouer; +Cc: Jiri Kosina, linux-kernel, netdev, joe
On Mon, Feb 4, 2013 at 2:14 PM, Jesper Dangaard Brouer
<brouer@redhat.com> wrote:
> Help people reading the percpu_counter code, to notice the ifdef
> else statement that seperates CONFIG_SMP.
>
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
> Acked-by: Tejun Heo <tj@kernel.org>
Jiri, can you please take this?
Thank you.
--
tejun
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [TRIVIAL PATCH V2] Doc: percpu_counter doc code for better readability
2013-02-04 22:10 ` Tejun Heo
@ 2013-02-05 10:54 ` Jiri Kosina
0 siblings, 0 replies; 5+ messages in thread
From: Jiri Kosina @ 2013-02-05 10:54 UTC (permalink / raw)
To: Tejun Heo; +Cc: Jesper Dangaard Brouer, linux-kernel, netdev, joe
On Mon, 4 Feb 2013, Tejun Heo wrote:
> > Help people reading the percpu_counter code, to notice the ifdef
> > else statement that seperates CONFIG_SMP.
> >
> > Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
> > Acked-by: Tejun Heo <tj@kernel.org>
>
> Jiri, can you please take this?
Absolutely, now applied. Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-02-05 10:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-29 8:31 [PATCH] Doc: percpu_counter doc code for better readability Jesper Dangaard Brouer
2013-02-04 21:49 ` Tejun Heo
2013-02-04 22:14 ` [TRIVIAL PATCH V2] " Jesper Dangaard Brouer
2013-02-04 22:10 ` Tejun Heo
2013-02-05 10:54 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).