From: David Miller <davem@davemloft.net>
To: oliver@neukum.org
Cc: bjorn@mork.no, netdev@vger.kernel.org, linux-usb@vger.kernel.org,
joe@perches.com
Subject: Re: [PATCH net v2] net: usbnet: prevent buggy devices from killing us
Date: Wed, 30 Jan 2013 17:36:33 -0500 (EST) [thread overview]
Message-ID: <20130130.173633.1911213197565689159.davem@davemloft.net> (raw)
In-Reply-To: <1784756.y7ETz6QMlb@linux-5eaq.site>
From: Oliver Neukum <oliver@neukum.org>
Date: Wed, 30 Jan 2013 08:44:35 +0100
> On Tuesday 29 January 2013 10:51:28 Bjørn Mork wrote:
>> A device sending 0 length frames as fast as it can has been
>> observed killing the host system due to the resulting memory
>> pressure.
>>
>> Temporarily disable RX skb allocation and URB submission when
>> the current error ratio is high, preventing us from trying to
>> allocate an infinite number of skbs. Reenable as soon as we
>> are finished processing the done queue, allowing the device
>> to continue working after short error bursts.
>>
>> Signed-off-by: Bjørn Mork <bjorn@mork.no>
> Acked-by: Oliver Neukum <oneukum@suse.de>
Applied, thanks.
prev parent reply other threads:[~2013-01-30 22:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 9:51 [PATCH net v2] net: usbnet: prevent buggy devices from killing us Bjørn Mork
2013-01-30 7:44 ` Oliver Neukum
2013-01-30 22:36 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130130.173633.1911213197565689159.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bjorn@mork.no \
--cc=joe@perches.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).