From: David Miller <davem@davemloft.net>
To: amirv@mellanox.com
Cc: netdev@vger.kernel.org, shanim@mellanox.com
Subject: Re: [PATCH net-next 09/11] net/mlx4_en: Add debugfs support
Date: Wed, 30 Jan 2013 20:23:07 -0500 (EST) [thread overview]
Message-ID: <20130130.202307.2012762623231158868.davem@davemloft.net> (raw)
In-Reply-To: <1359542067-10760-10-git-send-email-amirv@mellanox.com>
From: Amir Vadai <amirv@mellanox.com>
Date: Wed, 30 Jan 2013 12:34:25 +0200
> Add debugfs support to the mlx4_en driver such that users have the ability to access
> kernel information which can be used by external tools e.g HW monitoring ones
>
> The filesystem is set up in the following driver/interface hierarchy:
> <debugfs>
Sigh...
This is a chronic problem.
Every time some driver developer can't figure out a way, using existing
well structured interfaces, to expose some information or statistic,
they just throw their hands in the air and add some debugfs turd.
Don't do this.
Instead, use or extend existing, well structured and typed, interfaces
to export your information.
That way every driver can export similar information in a familiar way
rather than with yet-another-debugfs-hack.
I'm not applying this series, sorry.
next prev parent reply other threads:[~2013-01-31 1:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 10:34 [PATCH net-next 00/11] Mellanox Ethernet driver updates 2013-01-30 Amir Vadai
2013-01-30 10:34 ` [PATCH net-next 01/11] net/mlx4_core: Directly expose fields of HW flow steering rule control segment Amir Vadai
2013-01-30 10:34 ` [PATCH net-next 02/11] net/mlx4_core: Set correctly allow_loopback flag Amir Vadai
2013-01-30 10:34 ` [PATCH net-next 03/11] net/mlx4_en: Fix ip/udp steering rules multicast mac when attached via ethtool Amir Vadai
2013-01-30 10:34 ` [PATCH net-next 04/11] net/mlx4_en: Validate VLAN IDs provided in ethtool flow steering rules Amir Vadai
2013-01-30 10:34 ` [PATCH net-next 05/11] net/mlx4_en: Fix vlan mask for ethtool " Amir Vadai
2013-01-30 17:20 ` Ben Hutchings
2013-01-30 10:34 ` [PATCH net-next 06/11] net/mlx4_en: Block insertion of ethtool steering rules while the interface is down Amir Vadai
2013-01-30 10:34 ` [PATCH net-next 07/11] net/mlx4_en: Fix ethtool rules leftovers after module unloaded Amir Vadai
2013-01-30 10:34 ` [PATCH net-next 08/11] net/mlx4_core: Use firmware driven flow steering hash mode Amir Vadai
2013-01-30 10:34 ` [PATCH net-next 09/11] net/mlx4_en: Add debugfs support Amir Vadai
2013-01-31 1:23 ` David Miller [this message]
2013-01-30 10:34 ` [PATCH net-next 10/11] net/mlx4_en: Don't reassign port mac address on firmware that supports it Amir Vadai
2013-01-30 10:34 ` [PATCH net-next 11/11] net/mlx4_en: Fix transmit timeout when driver restarts port Amir Vadai
2013-01-30 16:50 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130130.202307.2012762623231158868.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=amirv@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=shanim@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).