From: David Miller <davem@davemloft.net>
To: tparkin@katalix.com
Cc: netdev@vger.kernel.org, jchapman@katalix.com, celston@katalix.com
Subject: Re: [PATCH v2 0/3] l2tp: fix ancillary data handling in ipv6 recv
Date: Wed, 30 Jan 2013 20:32:21 -0500 (EST) [thread overview]
Message-ID: <20130130.203221.113672899098479942.davem@davemloft.net> (raw)
In-Reply-To: <1359555686-21588-1-git-send-email-tparkin@katalix.com>
From: Tom Parkin <tparkin@katalix.com>
Date: Wed, 30 Jan 2013 14:21:23 +0000
> Patch 0001 includes some minor whitespace change in order to comply with
> checkpatch.pl's style recommendations.
Those whitspace recommendations do not match what we use in the
networking.
A function call shall be indented like so:
ret = func(arg1, arg2, arg3,
arg4, arg5, arg6);
That is, the arguments on the second and subsequent lines shall
be indented to the first column after the openning parenthesis
of the first line.
You must use whatever combination of TAB and space characters are
necessary to achieve it.
If you are indenting only using TAB characters, it is guarenteed
that you are doing it wrong.
You also need to reindent the arguments in function declarations in
the header files that you modified. The function name is longer on
the first line, therefore the openning parenthesis appears deeper in
the line, and therefore the second and further lines of the
declaration have to be indent adjusted.
Thanks.
prev parent reply other threads:[~2013-01-31 1:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 14:21 [PATCH v2 0/3] l2tp: fix ancillary data handling in ipv6 recv Tom Parkin
2013-01-30 14:21 ` [PATCH v2 1/3] ipv6: rename datagram_send_ctl and datagram_recv_ctl Tom Parkin
2013-01-30 14:21 ` [PATCH v2 2/3] ipv6: export ip6_datagram_recv_ctl Tom Parkin
2013-01-30 14:21 ` [PATCH v2 3/3] l2tp: correctly handle ancillary data in the ip6 recv path Tom Parkin
2013-01-31 1:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130130.203221.113672899098479942.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=celston@katalix.com \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
--cc=tparkin@katalix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).