From: Wolfram Sang <w.sang@pengutronix.de>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
Shawn Guo <shawn.guo@freescale.com>
Subject: Re: [RFC 3/3] arm: mach-mxs: make enabling enet_out a legacy function
Date: Wed, 30 Jan 2013 08:58:32 +0100 [thread overview]
Message-ID: <20130130075832.GA13075@pengutronix.de> (raw)
In-Reply-To: <20130130054833.GA24450@S2100-06.ap.freescale.net>
[-- Attachment #1: Type: text/plain, Size: 861 bytes --]
On Wed, Jan 30, 2013 at 01:48:40PM +0800, Shawn Guo wrote:
> On Tue, Jan 29, 2013 at 03:46:13PM +0100, Wolfram Sang wrote:
> > @@ -351,7 +359,7 @@ static void __init tx28_post_init(void)
> > struct pinctrl *pctl;
> > int ret;
> >
> > - enable_clk_enet_out();
> > + legacy_enable_clk_enet_out();
>
> I think TX28 is the only case that really needs to turn on enet_out
> clock at platform level, since it has some dirty work about PHY to do
> here. With with fec driver handling the clock, enable_clk_enet_out()
> can just be removed for other boards.
I would love to, but this will cause regression on boards which update
the kernel but not the devicetree (no third clock), or?
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-01-30 7:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 14:46 [RFC 0/3] arm: mxs: sanitize enet_out clock handling Wolfram Sang
2013-01-29 14:46 ` [RFC 1/3] net: freescale: fec: add support for optional enet_out clk Wolfram Sang
2013-01-30 5:25 ` Shawn Guo
2013-01-31 15:12 ` Wolfram Sang
2013-01-29 14:46 ` [RFC 2/3] arm: mxs: add enet_out clock to devicetree Wolfram Sang
2013-01-29 14:46 ` [RFC 3/3] arm: mach-mxs: make enabling enet_out a legacy function Wolfram Sang
2013-01-30 5:48 ` Shawn Guo
2013-01-30 7:58 ` Wolfram Sang [this message]
2013-01-30 12:29 ` Shawn Guo
2013-03-15 5:30 ` [RFC 0/3] arm: mxs: sanitize enet_out clock handling Trent Piepho
2013-03-15 21:27 ` Trent Piepho
2013-03-18 6:40 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130130075832.GA13075@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=shawn.guo@freescale.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).