From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, fbl@redhat.com
Subject: Re: [patch net-next v2 1/3] team: handle sending port list in the same way option list is sent
Date: Fri, 1 Feb 2013 21:43:10 +0100 [thread overview]
Message-ID: <20130201204310.GA3793@localhost> (raw)
In-Reply-To: <20130201190026.GA1627@minipsycho.brq.redhat.com>
On Fri, Feb 01, 2013 at 08:00:26PM +0100, Jiri Pirko wrote:
> >> +send_done:
> >> + nlh = nlmsg_put(skb, portid, seq, NLMSG_DONE, 0, flags | NLM_F_MULTI);
> >> + if (!nlh) {
> >> + err = __send_and_alloc_skb(&skb, team, portid, send_func);
> >> + if (err)
> >> + goto errout;
> >> + goto send_done;
> >> + }
> >
> >I'd suggest to use netlink_dump_start for this, so you don't need to
> >manually create the NLMSG_DONE message.
>
> I believe that is not possible for genl
By looking at net/netlink/genetlink.c, you can make it by means of the
.dumpit callback in struct genl_ops. You have to pass NLM_F_DUMP from
user-space to hit that code.
BTW, perhaps it is good idea to keep the old get function that takes
no NLM_F_DUMP for a while to avoid breaking old versions of userspace
code?
next prev parent reply other threads:[~2013-02-01 20:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 18:17 [patch net-next v2 0/3] team: couple of patches Jiri Pirko
2013-02-01 18:17 ` [patch net-next v2 1/3] team: handle sending port list in the same way option list is sent Jiri Pirko
2013-02-01 18:30 ` Pablo Neira Ayuso
2013-02-01 19:00 ` Jiri Pirko
2013-02-01 20:43 ` Pablo Neira Ayuso [this message]
2013-02-01 23:31 ` Jiri Pirko
2013-02-02 1:29 ` Pablo Neira Ayuso
2013-02-02 9:04 ` Jiri Pirko
2013-02-04 16:03 ` Pablo Neira Ayuso
2013-02-04 16:28 ` Jiri Pirko
2013-02-05 0:28 ` Pablo Neira Ayuso
2013-02-01 18:17 ` [patch net-next v2 2/3] team: move netlink event notifiers after team_port_leave() Jiri Pirko
2013-02-01 18:17 ` [patch net-next v2 3/3] team: ab: set active port option as changed when port is leaving Jiri Pirko
2013-02-04 19:56 ` [patch net-next v2 0/3] team: couple of patches David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130201204310.GA3793@localhost \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=fbl@redhat.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).