From: Stephen Hemminger <stephen@networkplumber.org>
To: nicolas.dichtel@6wind.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] iplink: display the value of IFLA_PROMISCUITY
Date: Mon, 4 Feb 2013 09:56:36 -0800 [thread overview]
Message-ID: <20130204095636.64b57bd0@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <510FEF97.7040903@6wind.com>
On Mon, 04 Feb 2013 18:27:51 +0100
Nicolas Dichtel <nicolas.dichtel@6wind.com> wrote:
> Le 04/02/2013 18:04, Stephen Hemminger a écrit :
> > On Mon, 28 Jan 2013 06:47:56 -0800
> > Nicolas Dichtel <nicolas.dichtel@6wind.com> wrote:
> >
> >> This is usefull to know the 'real' status of an interface (the flag IFF_PROMISC
> >> is exported by the kernel only when the user set it explicitly, for example it
> >> will not be exported when a tcpdump is running).
> >>
> >> Note that I add a space after qlen (instead of before promiscuity) to be
> >> coherent with the rest of the code.
> >>
> >> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> >> ---
> >> ip/ipaddress.c | 5 ++++-
> >> 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > The idea is good, but I can't accept in the current form.
> > The problem with this is that it violates the unwritten assumption that the output
> > of ip command should be the arguments used to setup that interface. There were even
> > some VPN's that depended on that.
> >
> Would it be acceptable to display this information when '-d' (ip -details link)
> is provided by the user?
Yeah, that seems to be where such things end up.
next prev parent reply other threads:[~2013-02-04 17:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CB4696DA7737D0409230B481D0363B1414F0E60461@HQ1-EXCH03.corp.brocade.com>
2013-02-04 17:04 ` [PATCH iproute2] iplink: display the value of IFLA_PROMISCUITY Stephen Hemminger
2013-02-04 17:27 ` Nicolas Dichtel
2013-02-04 17:56 ` Stephen Hemminger [this message]
2013-02-05 8:28 ` [PATCH iproute2 v2] " Nicolas Dichtel
2013-01-28 14:38 [PATCH iproute2] " Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204095636.64b57bd0@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox