From: Tejun Heo <tj@kernel.org>
To: chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil>
Cc: akpm@linux-foundation.org, rusty@rustcorp.com.au,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v2 02/14] atm/nicstar: don't use idr_remove_all()
Date: Mon, 4 Feb 2013 10:35:08 -0800 [thread overview]
Message-ID: <20130204183508.GU27963@mtj.dyndns.org> (raw)
In-Reply-To: <20130204131034.5bea17c4@thirdoffive.cmf.nrl.navy.mil>
Hey,
On Mon, Feb 04, 2013 at 01:10:34PM -0500, chas williams - CONTRACTOR wrote:
> you assign id1 to 0, so this never happens i think. i don't think the
> reason to preassign id1/id2 exists anymore once the do loop is removed.
>
> > + id1 = idr_alloc(&card->idr, handle1, 0, 0, GFP_ATOMIC);
> > + if (id1 < 0) {
> > + err = id1;
>
> you dont need to assign err since it isn't returned.
Heh, I put v2 under the wrong thread. I'll do v3 and post it under
v1.
Thanks.
--
tejun
prev parent reply other threads:[~2013-02-04 18:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1359163872-1949-1-git-send-email-tj@kernel.org>
2013-01-26 1:31 ` [PATCH 02/14] atm/nicstar: don't use idr_remove_all() Tejun Heo
2013-01-27 6:43 ` David Miller
2013-02-04 17:52 ` [PATCH v2 " Tejun Heo
2013-02-04 18:10 ` chas williams - CONTRACTOR
2013-02-04 18:35 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204183508.GU27963@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chas@cmf.nrl.navy.mil \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).