From: Tejun Heo <tj@kernel.org>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: joe@perches.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Doc: percpu_counter doc code for better readability
Date: Mon, 4 Feb 2013 13:49:52 -0800 [thread overview]
Message-ID: <20130204214952.GJ27963@mtj.dyndns.org> (raw)
In-Reply-To: <20130129083156.20701.33948.stgit@dragon>
On Tue, Jan 29, 2013 at 09:31:56AM +0100, Jesper Dangaard Brouer wrote:
> Help people reading the percpu_counter code, to notice the ifdef
> else statement that seperates CONFIG_SMP.
>
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
> ---
>
> include/linux/percpu_counter.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/linux/percpu_counter.h b/include/linux/percpu_counter.h
> index b9df9ed..eded1aa 100644
> --- a/include/linux/percpu_counter.h
> +++ b/include/linux/percpu_counter.h
> @@ -83,7 +83,7 @@ static inline int percpu_counter_initialized(struct percpu_counter *fbc)
> return (fbc->counters != NULL);
> }
>
> -#else
> +#else /* No CONFIG_SMP */
"#else /* !CONFIG_SMP */" would be more conventional. Can you please
change that and repost it w/ my Acked-by and [TRIVIAL] tag added and
Jiri Kosina <trivial@kernel.org> cc'd?
Thanks.
--
tejun
next prev parent reply other threads:[~2013-02-04 21:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-29 8:31 [PATCH] Doc: percpu_counter doc code for better readability Jesper Dangaard Brouer
2013-02-04 21:49 ` Tejun Heo [this message]
2013-02-04 22:14 ` [TRIVIAL PATCH V2] " Jesper Dangaard Brouer
2013-02-04 22:10 ` Tejun Heo
2013-02-05 10:54 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204214952.GJ27963@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=brouer@redhat.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).