netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ycheng@google.com
Cc: stephen@networkplumber.org, netdev@vger.kernel.org
Subject: Re: [PATCH] tcp: remove Appropriate Byte Count support
Date: Tue, 05 Feb 2013 14:46:35 -0500 (EST)	[thread overview]
Message-ID: <20130205.144635.1648371589019378147.davem@davemloft.net> (raw)
In-Reply-To: <CAK6E8=dCgNgGpQK=oMBz3c0c8Scj4nwi5OS7r4QWrrxhiJsXFw@mail.gmail.com>

From: Yuchung Cheng <ycheng@google.com>
Date: Tue, 5 Feb 2013 09:47:59 -0800

> On Tue, Feb 5, 2013 at 9:25 AM, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
>> TCP Appropriate Byte Count was added by me, but later disabled.
>> There is no point in maintaining it since it is a potential source
>> of bugs and Linux already implements other better window protection
>> heuristics.
> +1
> 
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Applied, and:

>>         tp->bytes_acked = 0;
> Is bytes_acked still needed?

I took care of this when I committed Stephen's patch.

Thanks.

      reply	other threads:[~2013-02-05 19:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-05 17:25 [PATCH] tcp: remove Appropriate Byte Count support Stephen Hemminger
2013-02-05 17:47 ` Yuchung Cheng
2013-02-05 19:46   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130205.144635.1648371589019378147.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).