From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, fbl@redhat.com
Subject: Re: [patch net-next v2 1/3] team: handle sending port list in the same way option list is sent
Date: Tue, 5 Feb 2013 01:28:43 +0100 [thread overview]
Message-ID: <20130205002842.GA11589@localhost> (raw)
In-Reply-To: <20130204162806.GA1544@minipsycho.orion>
On Mon, Feb 04, 2013 at 05:28:06PM +0100, Jiri Pirko wrote:
> Mon, Feb 04, 2013 at 05:03:04PM CET, pablo@netfilter.org wrote:
> >On Sat, Feb 02, 2013 at 10:04:22AM +0100, Jiri Pirko wrote:
[...]
> >> Messages are too big to fit one GENLMSG_DEFAULT_SIZE message.
> >
> >nfnetlink_log may use bigger messages than 1 memory page to deliver
> >multicast events if configured to include the entire packet
> >(NFULNL_COPY_PACKET).
> >
> >I'd suggest to calculate the message size in run-time and allocate
> >memory you need according to that, several netfilter subsystem are
> >doing so.
>
> I recall I had some issues with longer messages on the userspace part,
> I'm not sure what that was exactly.
Hm, it should be OK.
> I decided to do this in multipart messages and in order to do not
> break userspace I would like to continue to do so.
It was just a suggestion.
Note that fitting the message in one single skb should also simplify
the handling in case you hit ENOBUFS from user-space. But you know
better your needs for the team driver, I leave this up to you.
next prev parent reply other threads:[~2013-02-05 0:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 18:17 [patch net-next v2 0/3] team: couple of patches Jiri Pirko
2013-02-01 18:17 ` [patch net-next v2 1/3] team: handle sending port list in the same way option list is sent Jiri Pirko
2013-02-01 18:30 ` Pablo Neira Ayuso
2013-02-01 19:00 ` Jiri Pirko
2013-02-01 20:43 ` Pablo Neira Ayuso
2013-02-01 23:31 ` Jiri Pirko
2013-02-02 1:29 ` Pablo Neira Ayuso
2013-02-02 9:04 ` Jiri Pirko
2013-02-04 16:03 ` Pablo Neira Ayuso
2013-02-04 16:28 ` Jiri Pirko
2013-02-05 0:28 ` Pablo Neira Ayuso [this message]
2013-02-01 18:17 ` [patch net-next v2 2/3] team: move netlink event notifiers after team_port_leave() Jiri Pirko
2013-02-01 18:17 ` [patch net-next v2 3/3] team: ab: set active port option as changed when port is leaving Jiri Pirko
2013-02-04 19:56 ` [patch net-next v2 0/3] team: couple of patches David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130205002842.GA11589@localhost \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=fbl@redhat.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).