From: "Michael S. Tsirkin" <mst@redhat.com>
To: alexander.h.duyck@intel.com, stephen.s.ko@intel.com,
jeffrey.t.kirsher@intel.com, David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: regression caused by 1d2024f61ec14bdb0c57a97a3fe73685abc2d198?
Date: Wed, 6 Feb 2013 13:43:21 +0200 [thread overview]
Message-ID: <20130206114321.GA13497@redhat.com> (raw)
It seems that starting with kernel 3.3 ixgbe sets gso_size for
incoming frames. It seems that this might result in gso_size
being set even when gso_type is 0.
This in turn leads to a crash at macvtap_skb_to_vnet_hdr
drivers/net/macvtap.c:628
which has this code:
if (skb_is_gso(skb)) {
struct skb_shared_info *sinfo = skb_shinfo(skb);
/* This is a hint as to how much should be linear. */
vnet_hdr->hdr_len = skb_headlen(skb);
vnet_hdr->gso_size = sinfo->gso_size;
if (sinfo->gso_type & SKB_GSO_TCPV4)
vnet_hdr->gso_type = VIRTIO_NET_HDR_GSO_TCPV4;
else if (sinfo->gso_type & SKB_GSO_TCPV6)
vnet_hdr->gso_type = VIRTIO_NET_HDR_GSO_TCPV6;
else if (sinfo->gso_type & SKB_GSO_UDP)
vnet_hdr->gso_type = VIRTIO_NET_HDR_GSO_UDP;
else
BUG();
if (sinfo->gso_type & SKB_GSO_TCP_ECN)
vnet_hdr->gso_type |= VIRTIO_NET_HDR_GSO_ECN;
} else
vnet_hdr->gso_type = VIRTIO_NET_HDR_GSO_NONE;
Since skb_is_gso tests gso_size.
What's the right way to handle this? Should skb_is_gso be
changed to test gso_type != 0?
--
MST
next reply other threads:[~2013-02-06 11:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 11:43 Michael S. Tsirkin [this message]
2013-02-06 13:07 ` regression caused by 1d2024f61ec14bdb0c57a97a3fe73685abc2d198? Eric Dumazet
2013-02-06 15:50 ` Michael S. Tsirkin
2013-02-06 16:15 ` Eric Dumazet
2013-02-06 17:42 ` Michael S. Tsirkin
2013-02-06 17:42 ` Eric Dumazet
2013-02-06 17:50 ` Michael S. Tsirkin
2013-02-06 18:05 ` Michael S. Tsirkin
2013-02-06 18:09 ` Eric Dumazet
2013-02-07 3:03 ` Cong Wang
2013-02-06 16:23 ` Eric Dumazet
2013-02-06 19:58 ` Ben Hutchings
2013-02-06 21:45 ` Michael S. Tsirkin
2013-02-06 21:55 ` Ben Hutchings
2013-02-06 22:26 ` Michael S. Tsirkin
2013-02-06 23:29 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130206114321.GA13497@redhat.com \
--to=mst@redhat.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=stephen.s.ko@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).