From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, jchapman@katalix.com, bircoph@gmail.com
Subject: Re: [PATCH] l2tp: dont play with skb->truesize
Date: Fri, 08 Feb 2013 01:50:46 -0500 (EST) [thread overview]
Message-ID: <20130208.015045.564376676195476016.davem@davemloft.net> (raw)
In-Reply-To: <1360281634.28557.71.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 07 Feb 2013 16:00:34 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> Andrew Savchenko reported a DNS failure and we diagnosed that
> some UDP sockets were unable to send more packets because their
> sk_wmem_alloc was corrupted after a while (tx_queue column in
> following trace)
...
> Playing with skb->truesize is tricky, especially when
> skb is attached to a socket, as we can fool memory charging.
>
> Just remove this code, its not worth trying to be ultra
> precise in xmit path.
>
> Reported-by: Andrew Savchenko <bircoph@gmail.com>
> Tested-by: Andrew Savchenko <bircoph@gmail.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2013-02-08 6:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 0:00 [PATCH] l2tp: dont play with skb->truesize Eric Dumazet
2013-02-08 6:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130208.015045.564376676195476016.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bircoph@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).