From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] arp: fix possible crash in arp_rcv()
Date: Sun, 10 Feb 2013 20:40:54 -0500 (EST) [thread overview]
Message-ID: <20130210.204054.1090844260063864067.davem@davemloft.net> (raw)
In-Reply-To: <1360385301.6696.11.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 08 Feb 2013 20:48:21 -0800
> From: Eric Dumazet <edumazet@google.com>
>
> We should call skb_share_check() before pskb_may_pull(), or we
> can crash in pskb_expand_head()
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
It's just a very odd set of combined circumstances we would
need for this to trigger and also cause a real problem of
any kind.
In any event, the fix is of course correct, and thus applied
to 'net'. Thanks Eric!
prev parent reply other threads:[~2013-02-11 1:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-09 4:48 [PATCH] arp: fix possible crash in arp_rcv() Eric Dumazet
2013-02-11 1:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130210.204054.1090844260063864067.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox