From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: YOSHIFUJI Hideaki <hideaki@yoshifuji.org>
Cc: netdev@vger.kernel.org, YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH] ipv6: by default join ff01::1 and in case of forwarding ff01::2 and ff05:2
Date: Sun, 10 Feb 2013 15:59:22 +0100 [thread overview]
Message-ID: <20130210145922.GG18219@order.stressinduktion.org> (raw)
In-Reply-To: <5117B306.4070402@yoshifuji.org>
On Sun, Feb 10, 2013 at 11:47:34PM +0900, YOSHIFUJI Hideaki wrote:
> > @@ -611,10 +617,15 @@ static void dev_forward_change(struct inet6_dev *idev)
> > if (idev->cnf.forwarding)
> > dev_disable_lro(dev);
> > if (dev->flags & IFF_MULTICAST) {
> > - if (idev->cnf.forwarding)
> > + if (idev->cnf.forwarding) {
> > ipv6_dev_mc_inc(dev, &in6addr_linklocal_allrouters);
> > - else
> > + ipv6_dev_mc_inc(dev, &in6addr_interfacelocal_allrouters);
> > + ipv6_dev_mc_inc(dev, &in6addr_sitelocal_allrouters);
> > + } else {
> > ipv6_dev_mc_dec(dev, &in6addr_linklocal_allrouters);
> > + ipv6_dev_mc_dec(dev, &in6addr_interfacelocal_allrouters);
> > + ipv6_dev_mc_inc(dev, &in6addr_sitelocal_allrouters);
> ~~~dec?
> > + }
> > }
Yes, that was the broken part. I fixed it locally and then send out the old
patch file.
prev parent reply other threads:[~2013-02-10 14:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-10 13:34 [PATCH] ipv6: by default join ff01::1 and in case of forwarding ff01::2 and ff05:2 Hannes Frederic Sowa
2013-02-10 13:42 ` Hannes Frederic Sowa
2013-02-10 14:47 ` YOSHIFUJI Hideaki
2013-02-10 14:59 ` Hannes Frederic Sowa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130210145922.GG18219@order.stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=hideaki@yoshifuji.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).