From: David Miller <davem@davemloft.net>
To: jiri@resnulli.us
Cc: netdev@vger.kernel.org, edumazet@google.com, jhs@mojatatu.com,
kuznet@ms2.inr.ac.ru, j.vimal@gmail.com
Subject: Re: [patch net-next v4 07/11] tbf: ignore max_size check for gso skbs
Date: Mon, 11 Feb 2013 16:11:07 -0500 (EST) [thread overview]
Message-ID: <20130211.161107.919817010099628482.davem@davemloft.net> (raw)
In-Reply-To: <20130211210220.GA1560@minipsycho.orion>
From: Jiri Pirko <jiri@resnulli.us>
Date: Mon, 11 Feb 2013 22:02:20 +0100
> Hmm. I think that this approach might not be correct after all. This
> might break existing setups when user is taking gso into account and
> adjust mtu and burst accordingly. After more thorough study, I'm under
> impression that gso skbs should not be handled in any different way.
>
> Thoughts?
I really think userspace should be ignorant of GSO to the maximum
extent to which that is possible.
next prev parent reply other threads:[~2013-02-11 21:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-10 10:52 [patch net-next v4 00/11] couple of net/sched fixes+improvements Jiri Pirko
2013-02-10 10:52 ` [patch net-next v4 01/11] htb: use PSCHED_TICKS2NS() Jiri Pirko
2013-02-10 10:52 ` [patch net-next v4 02/11] htb: fix values in opt dump Jiri Pirko
2013-02-10 10:52 ` [patch net-next v4 03/11] htb: remove pointless first initialization of buffer and cbuffer Jiri Pirko
2013-02-10 10:52 ` [patch net-next v4 04/11] htb: initialize cl->tokens and cl->ctokens correctly Jiri Pirko
2013-02-10 10:52 ` [patch net-next v4 05/11] sch: make htb_rate_cfg and functions around that generic Jiri Pirko
2013-02-10 10:52 ` [patch net-next v4 06/11] tbf: improved accuracy at high rates Jiri Pirko
2013-02-10 10:52 ` [patch net-next v4 07/11] tbf: ignore max_size check for gso skbs Jiri Pirko
2013-02-11 21:02 ` Jiri Pirko
2013-02-11 21:11 ` David Miller [this message]
2013-02-10 10:52 ` [patch net-next v4 08/11] tbf: fix value set for q->ptokens Jiri Pirko
2013-02-10 10:52 ` [patch net-next v4 09/11] act_police: move struct tcf_police to act_police.c Jiri Pirko
2013-02-10 10:52 ` [patch net-next v4 10/11] act_police: improved accuracy at high rates Jiri Pirko
2013-02-10 10:52 ` [patch net-next v4 11/11] act_police: remove <=mtu check for gso skbs Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130211.161107.919817010099628482.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.vimal@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).