From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Malat Subject: [PATCH] phy: fix phy_device_free memory leak Date: Mon, 11 Feb 2013 12:28:27 +0100 Message-ID: <20130211112827.GA24817@bordel.klfree.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: oss@malat.biz To: netdev@vger.kernel.org Return-path: Received: from mail-ee0-f49.google.com ([74.125.83.49]:39853 "EHLO mail-ee0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754750Ab3BKLZE (ORCPT ); Mon, 11 Feb 2013 06:25:04 -0500 Received: by mail-ee0-f49.google.com with SMTP id d4so3108587eek.8 for ; Mon, 11 Feb 2013 03:25:00 -0800 (PST) Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: From: Petr Malat Fix memory leak in phy_device_free() for the case when phy_device* returned by phy_device_create() is not registered in the system. Signed-off-by: Petr Malat --- Bug description: phy_device_create() sets name of kobject using dev_set_name(), which allocates memory using kvasprintf(), but this memory isn't freed if the underlying device isn't registered properly, because kobject_cleanup() is not called in that case. This can happen (and actually is happening on our machines) if phy_device_register(), called by mdiobus_scan(), fails. Patch description: Name is freed by phy_device_free(). In the case a device is released trough kobject_cleanup()->device_release()->phy_device_release(), the name is set to NULL and it is not freed by phy_device_free(), because it will be freed later by kobject_cleanup(). Please put me on CC, I'm not signed into the mailing list. --- linux-v2.6.32.60.orig/drivers/net/phy/phy_device.c 2013-02-06 19:44:11.000000000 +0100 +++ linux-v2.6.32.60/drivers/net/phy/phy_device.c 2013-02-06 20:56:57.000000000 +0100 @@ -41,12 +41,16 @@ MODULE_LICENSE("GPL"); void phy_device_free(struct phy_device *phydev) { + kfree(phydev->dev.kobj.name); kfree(phydev); } EXPORT_SYMBOL(phy_device_free); static void phy_device_release(struct device *dev) { + /* Name will be freed by kobject_cleanup() */ + dev->kobj.name = NULL; + phy_device_free(to_phy_device(dev)); }