From: David Miller <davem@davemloft.net>
To: pshelar@nicira.com
Cc: edumazet@google.com, netdev@vger.kernel.org, jesse@nicira.com,
bhutchings@solarflare.com
Subject: Re: [PATCH] net: Fix possible wrong checksum generation.
Date: Wed, 13 Feb 2013 13:31:07 -0500 (EST) [thread overview]
Message-ID: <20130213.133107.1252368625820641730.davem@davemloft.net> (raw)
In-Reply-To: <1360610861-1753-1-git-send-email-pshelar@nicira.com>
From: Pravin B Shelar <pshelar@nicira.com>
Date: Mon, 11 Feb 2013 11:27:41 -0800
> Patch cef401de7be8c4e (net: fix possible wrong checksum
> generation) fixed wrong checksum calculation but it broke TSO by
> defining new GSO type but not a netdev feature for that type.
> net_gso_ok() would not allow hardware checksum/segmentation
> offload of such packets without the feature.
>
> Following patch fixes TSO and wrong checksum. This patch uses
> same logic that Eric Dumazet used. Patch introduces new flag
> SKBTX_SHARED_FRAG if at least one frag can be modified by
> the user. but SKBTX_SHARED_FRAG flag is kept in skb shared
> info tx_flags rather than gso_type.
>
> tx_flags is better compared to gso_type since we can have skb with
> shared frag without gso packet. It does not link SHARED_FRAG to
> GSO, So there is no need to define netdev feature for this.
>
> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>
Applied, thanks.
prev parent reply other threads:[~2013-02-13 18:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 19:27 [PATCH] net: Fix possible wrong checksum generation Pravin B Shelar
2013-02-13 18:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213.133107.1252368625820641730.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=edumazet@google.com \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).