From: David Miller <davem@davemloft.net>
To: dborkman@redhat.com
Cc: linux-sctp@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: sctp: minor: make jsctp_sf_eat_sack static
Date: Wed, 13 Feb 2013 14:06:07 -0500 (EST) [thread overview]
Message-ID: <20130213.140607.144614341798606281.davem@davemloft.net> (raw)
In-Reply-To: <20130213.140436.521031425285650154.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 13 Feb 2013 14:04:36 -0500 (EST)
> From: Daniel Borkmann <dborkman@redhat.com>
> Date: Wed, 13 Feb 2013 12:03:49 +0100
>
>> The function jsctp_sf_eat_sack can be made static, no need to extend
>> its visibility.
>>
>> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
>
> It's exported for the jprobe lookup by ->symbol_name
>
> Did you test this?
Never mind, I mis-read this, the symbol name is for the routine being
shadowed by the jprobe, which is exported.
These two patches look fine and I'll apply them, thanks Daniel.
next prev parent reply other threads:[~2013-02-13 19:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1360752304.git.dborkman@redhat.com>
2013-02-13 11:03 ` [PATCH net-next 1/2] net: sctp: minor: make jsctp_sf_eat_sack static Daniel Borkmann
2013-02-13 19:04 ` David Miller
2013-02-13 19:06 ` David Miller [this message]
2013-02-13 19:14 ` Daniel Borkmann
2013-02-13 21:02 ` Neil Horman
2013-02-13 11:03 ` [PATCH net-next 2/2] net: sctp: add build check for sctp_sf_eat_sack_6_2/jsctp_sf_eat_sack Daniel Borkmann
2013-02-13 21:15 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213.140607.144614341798606281.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox