From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Cc: Brian Haley <brian.haley@hp.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] ipv6: use newly introduced __ipv6_addr_needs_scope_id and ipv6_iface_scope_id
Date: Wed, 13 Feb 2013 18:21:48 +0100 [thread overview]
Message-ID: <20130213172148.GA24534@order.stressinduktion.org> (raw)
In-Reply-To: <511BC3B3.3070405@linux-ipv6.org>
On Thu, Feb 14, 2013 at 01:47:47AM +0900, YOSHIFUJI Hideaki wrote:
> If you have several address checks around, please use ipv6_addr_type()
> (or __ipv6_addr_type()). Above "direct" checks should be used only for
> single-shot test. But well, I have to agree that ipv6_addr_type and
> friends is becoming complex. In mid-term, I would like to take look
> at it. I might think of having addr_type for src/dst in skb->cb
> after all.
Yes, I had no plan to duplicate addrconf_core tests. I just thought about
a) not using addr_types at all in the new helper functions
b) use something like
union ipv6_addr_type {
struct {
__u16 scope;
__u16 addr_type;
};
__u32 type_and_scope;
}
and explicitly use this in __ipv6_addr_type (this function does not seam to be
used as often as ipv6_addr_type).
next prev parent reply other threads:[~2013-02-13 17:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 22:16 [PATCH net-next 2/3] ipv6: use newly introduced __ipv6_addr_needs_scope_id and ipv6_iface_scope_id Hannes Frederic Sowa
2013-02-13 0:13 ` Hannes Frederic Sowa
2013-02-13 2:51 ` Brian Haley
2013-02-13 10:33 ` Hannes Frederic Sowa
2013-02-13 16:47 ` YOSHIFUJI Hideaki
2013-02-13 17:21 ` Hannes Frederic Sowa [this message]
2013-02-14 4:25 ` Hannes Frederic Sowa
2013-02-14 15:25 ` Brian Haley
2013-02-14 18:53 ` Hannes Frederic Sowa
2013-02-14 19:31 ` Brian Haley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213172148.GA24534@order.stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=brian.haley@hp.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).