From: David Miller <davem@davemloft.net>
To: bjorn@mork.no
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
gsuarez@smithmicro.com, alexey.orishko@stericsson.com
Subject: Re: [PATCH] net: cdc_ncm: fix probing of devices with multiple control interface altsettings
Date: Thu, 14 Feb 2013 13:15:16 -0500 (EST) [thread overview]
Message-ID: <20130214.131516.1338992153364367929.davem@davemloft.net> (raw)
In-Reply-To: <1360793392-7412-1-git-send-email-bjorn@mork.no>
From: Bjørn Mork <bjorn@mork.no>
Date: Wed, 13 Feb 2013 23:09:52 +0100
> commit bd329e1 ("net: cdc_ncm: do not bind to NCM compatible MBIM devices")
> added a test for a CDC MBIM altsetting, implementing the cdc_ncm part of
> MBIM backward compatibility support. This intentionally made the driver
> behave differently for CDC NCM devices with 2 alternate settings for the
> Communication interface, depending on whether or not CONFIG_USB_NET_CDC_MBIM
> was enabled. This is correct iff alternate setting #1 really *is* a MBIM
> setting. If not, then NCM probing will use a different altsetting than before,
> possibly causing probing failures depending on CONFIG_USB_NET_CDC_MBIM.
>
> Fix by setting the altsetting back to default after the test, restoring the
> previous behaviour for non MBIM devices.
>
> This bug causes probing of Huawei E3276 devices to fail when the MBIM driver
> is enabled, because these devices have a second alternate setting with no CDC
> functional descriptors.
>
> Cc: Greg Suarez <gsuarez@smithmicro.com>
> Cc: Alexey Orishko <alexey.orishko@stericsson.com>
> Reported-and-tested-by: Jonathan A. <yo.natan@hotmail.com>
> Signed-off-by: Bjørn Mork <bjorn@mork.no>
Applied.
prev parent reply other threads:[~2013-02-14 18:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-13 22:09 [PATCH] net: cdc_ncm: fix probing of devices with multiple control interface altsettings Bjørn Mork
2013-02-14 18:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130214.131516.1338992153364367929.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexey.orishko@stericsson.com \
--cc=bjorn@mork.no \
--cc=gsuarez@smithmicro.com \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).