[PATCH] bgmac: add read of interrupt mask after disabling interrupts

[PATCH] bgmac: add read of interrupt mask after disabling interrupts

[Nathan Hintz]

The specs prescribe an immediate read of the interrupt mask after
disabling interrupts.  This patch updates the driver to match the
specs.

Signed-off-by: Nathan Hintz <nlhintz@hotmail.com>
---
 drivers/net/ethernet/broadcom/bgmac.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
index 52d9a54..d341090 100644
--- a/drivers/net/ethernet/broadcom/bgmac.c
+++ b/drivers/net/ethernet/broadcom/bgmac.c
@@ -974,6 +974,7 @@ static void bgmac_chip_intrs_on(struct bgmac *bgmac)
 static void bgmac_chip_intrs_off(struct bgmac *bgmac)
 {
 	bgmac_write(bgmac, BGMAC_INT_MASK, 0);
+	bgmac_read(bgmac, BGMAC_INT_MASK);
 }
 
 /* http://bcm-v4.sipsolutions.net/mac-gbit/gmac/gmac_enable */
-- 
1.7.7.6

Re: [PATCH] bgmac: add read of interrupt mask after disabling interrupts

[David Miller]

From: Nathan Hintz <nlhintz@hotmail.com>
Date: Wed, 13 Feb 2013 21:14:10 -0800

> The specs prescribe an immediate read of the interrupt mask after
> disabling interrupts.  This patch updates the driver to match the
> specs.
> 
> Signed-off-by: Nathan Hintz <nlhintz@hotmail.com>

Applied to net-next.

Please state clearly, in your Subject line, what tree your patch is
targetted at.  In this case "[PATCH net-next] " would have been
an appropriate subject prefix.