From: David Miller <davem@davemloft.net>
To: hannes@stressinduktion.org
Cc: eric.dumazet@gmail.com, tt.rantala@gmail.com,
netdev@vger.kernel.org, davej@redhat.com, xemul@parallels.com
Subject: Re: [PATCH] net: fix infinite loop in __skb_recv_datagram()
Date: Fri, 15 Feb 2013 13:56:00 -0500 (EST) [thread overview]
Message-ID: <20130215.135600.962022690327903176.davem@davemloft.net> (raw)
In-Reply-To: <20130215124141.GB20018@order.stressinduktion.org>
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Fri, 15 Feb 2013 13:41:41 +0100
> On Tue, Feb 12, 2013 at 04:07:33PM -0500, David Miller wrote:
>> From: Eric Dumazet <eric.dumazet@gmail.com>
>> Date: Tue, 12 Feb 2013 08:16:53 -0800
>>
>> > From: Eric Dumazet <edumazet@google.com>
>> >
>> > Tommi was fuzzing with trinity and reported the following problem :
>> >
>> > commit 3f518bf745 (datagram: Add offset argument to __skb_recv_datagram)
>> > missed that a raw socket receive queue can contain skbs with no payload.
>> >
>> > We can loop in __skb_recv_datagram() with MSG_PEEK mode, because
>> > wait_for_packet() is not prepared to skip these skbs.
>> ...
>> > Reported-by: Tommi Rantala <tt.rantala@gmail.com>
>> > Tested-by: Tommi Rantala <tt.rantala@gmail.com>
>> > Signed-off-by: Eric Dumazet <edumazet@google.com>
>>
>> Applied, thanks.
>
> This issue got a CVE: http://seclists.org/oss-sec/2013/q1/310
> Perhaps it's something that should go to stable?
It's already queued up in my -stable queue.
prev parent reply other threads:[~2013-02-15 18:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 19:25 soft lockup at __skb_recv_datagram() when fuzzing with trinity as root in VM Tommi Rantala
2013-02-12 0:19 ` Eric Dumazet
2013-02-12 3:15 ` Eric Dumazet
2013-02-12 7:42 ` Tommi Rantala
2013-02-12 16:16 ` [PATCH] net: fix infinite loop in __skb_recv_datagram() Eric Dumazet
2013-02-12 16:18 ` Pavel Emelyanov
2013-02-12 21:07 ` David Miller
2013-02-15 12:41 ` Hannes Frederic Sowa
2013-02-15 17:43 ` Ben Hutchings
2013-02-15 17:55 ` Hannes Frederic Sowa
2013-02-15 18:56 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130215.135600.962022690327903176.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=davej@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
--cc=tt.rantala@gmail.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).