From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: fix infinite loop in __skb_recv_datagram() Date: Fri, 15 Feb 2013 13:56:00 -0500 (EST) Message-ID: <20130215.135600.962022690327903176.davem@davemloft.net> References: <1360685813.13993.12.camel@edumazet-glaptop> <20130212.160733.2235089567079483883.davem@davemloft.net> <20130215124141.GB20018@order.stressinduktion.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: eric.dumazet@gmail.com, tt.rantala@gmail.com, netdev@vger.kernel.org, davej@redhat.com, xemul@parallels.com To: hannes@stressinduktion.org Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:43548 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750784Ab3BOS4C (ORCPT ); Fri, 15 Feb 2013 13:56:02 -0500 In-Reply-To: <20130215124141.GB20018@order.stressinduktion.org> Sender: netdev-owner@vger.kernel.org List-ID: From: Hannes Frederic Sowa Date: Fri, 15 Feb 2013 13:41:41 +0100 > On Tue, Feb 12, 2013 at 04:07:33PM -0500, David Miller wrote: >> From: Eric Dumazet >> Date: Tue, 12 Feb 2013 08:16:53 -0800 >> >> > From: Eric Dumazet >> > >> > Tommi was fuzzing with trinity and reported the following problem : >> > >> > commit 3f518bf745 (datagram: Add offset argument to __skb_recv_datagram) >> > missed that a raw socket receive queue can contain skbs with no payload. >> > >> > We can loop in __skb_recv_datagram() with MSG_PEEK mode, because >> > wait_for_packet() is not prepared to skip these skbs. >> ... >> > Reported-by: Tommi Rantala >> > Tested-by: Tommi Rantala >> > Signed-off-by: Eric Dumazet >> >> Applied, thanks. > > This issue got a CVE: http://seclists.org/oss-sec/2013/q1/310 > Perhaps it's something that should go to stable? It's already queued up in my -stable queue.