netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
	jhs@mojatatu.com, kuznet@ms2.inr.ac.ru, j.vimal@gmail.com
Subject: Re: [patch net-next RFC] tbf: handle gso skbs properly
Date: Fri, 15 Feb 2013 15:28:47 +0100	[thread overview]
Message-ID: <20130215142847.GA1543@minipsycho.orion> (raw)
In-Reply-To: <1360937929.6884.82.camel@edumazet-glaptop>

Thanks for review Eric. I will process your suggestions and submit the
patch.


Fri, Feb 15, 2013 at 03:18:49PM CET, eric.dumazet@gmail.com wrote:
>On Fri, 2013-02-15 at 13:44 +0100, Jiri Pirko wrote:
>> According to Eric's suggestion, when gso skb can't be sent in one mtu
>> time, resegment it.
>> 
>> Note that helper will be moved to sch_api.c probably so it can be used
>> by other code.
>> 
>> Also, I'm not sure similar patch to this can be done for act_police. I
>> have to look at that more closely.


Any idea how to fix this in act_police? I believe we can't use the same
approach since there is no queue there.

Thanks.

Jiri

  reply	other threads:[~2013-02-15 14:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-15 12:44 [patch net-next RFC] tbf: handle gso skbs properly Jiri Pirko
2013-02-15 14:18 ` Eric Dumazet
2013-02-15 14:28   ` Jiri Pirko [this message]
2013-02-15 15:30 ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130215142847.GA1543@minipsycho.orion \
    --to=jiri@resnulli.us \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=j.vimal@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).