From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [BUG arm-soc] mvneta: tx queue done sometimes causes kernel panic Date: Sat, 16 Feb 2013 02:20:43 +0100 Message-ID: <20130216022043.65d5c940@skate> References: <511DE679.5080801@hitachi.com> <1360947132.19353.15.camel@edumazet-glaptop> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Masami Hiramatsu , linux-arm-kernel@lists.infradead.org, "yrl.pp-manager.tt@hitachi.com" , linux-kernel , "David S. Miller" , netdev To: Eric Dumazet Return-path: In-Reply-To: <1360947132.19353.15.camel@edumazet-glaptop> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hello, On Fri, 15 Feb 2013 08:52:12 -0800, Eric Dumazet wrote: > Driver is buggy, as TX completion can happen both from ndo_start_xmit() > and a timer, and there is no spinlock or appropriate synchro. Yes, it is a known issue. I did post a patch fixing the problem on netdev@ a while ago [1], but while it was fixing the problem, it wasn't considered the right approach. Being busy with other Marvell Armada 370/XP developments, I haven't yet had the time to investigate the issue again. [1] https://patchwork.kernel.org/patch/1941601/ Best regards, Thomas -- Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com