From: David Miller <davem@davemloft.net>
To: fubar@us.ibm.com
Cc: nikolay@redhat.com, netdev@vger.kernel.org, andy@greyhouse.net
Subject: Re: [PATCH net 2/3] bonding: Fix initialize after use for 3ad machine state spinlock
Date: Tue, 19 Feb 2013 00:52:47 -0500 (EST) [thread overview]
Message-ID: <20130219.005247.363934836692752429.davem@davemloft.net> (raw)
In-Reply-To: <21258.1361223190@death.nxdomain>
From: Jay Vosburgh <fubar@us.ibm.com>
Date: Mon, 18 Feb 2013 13:33:10 -0800
> Nikolay Aleksandrov <nikolay@redhat.com> wrote:
>
>>The 3ad machine state spinlock can be used before it is inititialized
>>while doing bond_enslave() (and the port is being initialized) since
>>port->slave is set before the lock is prepared, thus causing soft
>>lock-ups and a multitude of other nasty bugs.
>
> Does this change cause the "uninitialized port" warnings in
> bond_3ad_state_machine_handler and bond_3ad_rx_indication to
> intermittently print during the enslavement process? If so (and it
> looks to me like it will), I think the warnings should be removed, since
> after this change, port->slave being NULL isn't really an error
> condition that needs a warning to the log.
>
>>Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
...
>>-static inline void __initialize_port_locks(struct port *port)
>>+static inline void __initialize_port_locks(struct slave *port)
>> {
>> // make sure it isn't called twice
>>- spin_lock_init(&(SLAVE_AD_INFO(port->slave).state_machine_lock));
>>+ spin_lock_init(&(SLAVE_AD_INFO(port).state_machine_lock));
>
> Change the name of the variable here, too, not just the type.
> This is confusing.
I made this adjustment and applied Nikolay's patch.
next prev parent reply other threads:[~2013-02-19 5:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 17:59 [PATCH net 1/3] bonding: Fix race condition between bond_enslave() and bond_3ad_update_lacp_rate() Nikolay Aleksandrov
2013-02-18 17:59 ` [PATCH net 2/3] bonding: Fix initialize after use for 3ad machine state spinlock Nikolay Aleksandrov
2013-02-18 21:33 ` Jay Vosburgh
2013-02-18 21:51 ` Nikolay Aleksandrov
2013-02-19 5:52 ` David Miller [this message]
2013-02-18 17:59 ` [PATCH net-next 3/3] bonding: fix bond_release_all inconsistencies Nikolay Aleksandrov
2013-02-18 21:56 ` Jay Vosburgh
2013-02-18 22:13 ` Nikolay Aleksandrov
2013-02-18 23:17 ` Jay Vosburgh
2013-02-18 21:09 ` [PATCH net 1/3] bonding: Fix race condition between bond_enslave() and bond_3ad_update_lacp_rate() Jay Vosburgh
2013-02-19 5:52 ` David Miller
2013-02-19 0:09 ` [PATCH net-next v2 3/3] bonding: fix bond_release_all inconsistencies Nikolay Aleksandrov
2013-02-19 3:12 ` Jay Vosburgh
2013-02-19 5:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130219.005247.363934836692752429.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).