From: David Miller <davem@davemloft.net>
To: Ian.Campbell@citrix.com
Cc: JBeulich@suse.com, drjones@redhat.com,
xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH] xen: netback: remove redundant xenvif_put
Date: Tue, 19 Feb 2013 13:06:07 -0500 (EST) [thread overview]
Message-ID: <20130219.130607.100487415380997622.davem@davemloft.net> (raw)
In-Reply-To: <1361264324.1051.61.camel@zakaz.uk.xensource.com>
From: Ian Campbell <Ian.Campbell@citrix.com>
Date: Tue, 19 Feb 2013 08:58:44 +0000
> On Tue, 2013-02-19 at 08:03 +0000, Jan Beulich wrote:
>> >>> On 19.02.13 at 06:53, David Miller <davem@davemloft.net> wrote:
>> > From: Andrew Jones <drjones@redhat.com>
>> > Date: Mon, 18 Feb 2013 21:29:20 +0100
>> >
>> >> netbk_fatal_tx_err() calls xenvif_carrier_off(), which does
>> >> a xenvif_put(). As callers of netbk_fatal_tx_err should only
>> >> have one reference to the vif at this time, then the xenvif_put
>> >> in netbk_fatal_tx_err is one too many.
>> >>
>> >> Signed-off-by: Andrew Jones <drjones@redhat.com>
>> >
>> > Applied.
>>
>> But this is wrong from all we can tell,
>
> Yes, please can this be reverted.
Done and I've annotated the revert commit message with as much
information as possible.
next prev parent reply other threads:[~2013-02-19 18:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-18 20:29 [PATCH] xen: netback: remove redundant xenvif_put Andrew Jones
2013-02-18 20:58 ` Wei Liu
2013-02-19 5:53 ` David Miller
2013-02-19 8:03 ` [Xen-devel] " Jan Beulich
2013-02-19 8:58 ` Andrew Jones
2013-02-19 8:58 ` Ian Campbell
2013-02-19 18:06 ` David Miller [this message]
2013-02-20 9:23 ` Ian Campbell
2013-02-19 13:47 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130219.130607.100487415380997622.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ian.Campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=drjones@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).