From: David Miller <davem@davemloft.net>
To: gaofeng@cn.fujitsu.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/3] net: proc: fix build failed when procfs is not configured
Date: Tue, 19 Feb 2013 13:19:26 -0500 (EST) [thread overview]
Message-ID: <20130219.131926.781333335958742182.davem@davemloft.net> (raw)
In-Reply-To: <1361270592-19492-1-git-send-email-gaofeng@cn.fujitsu.com>
From: Gao feng <gaofeng@cn.fujitsu.com>
Date: Tue, 19 Feb 2013 18:43:10 +0800
> commit d4beaa66add8aebf83ab16d2fde4e4de8dac36df
> "net: proc: change proc_net_fops_create to proc_create"
> uses proc_create to replace proc_net_fops_create, when
> CONFIG_PROC isn't configured, some build error will
> occurs.
>
> net/packet/af_packet.c: In function 'packet_net_init':
> net/packet/af_packet.c:3831:48: error: 'packet_seq_fops' undeclared (first use in this function)
> net/packet/af_packet.c:3831:48: note: each undeclared identifier is reported only once for each function it appears in
>
> There may be other build fails like above,this patch
> change proc_create from function to macros when CONFIG_PROC
> is not configured,just like what proc_net_fops_create did
> before this commit.
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
Applied.
prev parent reply other threads:[~2013-02-19 18:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 10:43 [PATCH 1/3] net: proc: fix build failed when procfs is not configured Gao feng
2013-02-19 10:43 ` [PATCH 2/3] net: dev: fix build failed when procfs is disabled Gao feng
2013-02-19 12:02 ` Cong Wang
2013-02-19 10:43 ` [PATCH 3/3] net: ipv4: fix waring -Wunused-variable Gao feng
2013-02-19 18:19 ` David Miller
2013-02-19 18:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130219.131926.781333335958742182.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gaofeng@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).