From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Jones Subject: Re: [Xen-devel] [PATCH] xen: netback: remove redundant xenvif_put Date: Tue, 19 Feb 2013 09:58:03 +0100 Message-ID: <20130219095803.17b28ec3@hawk.usersys.redhat.com> References: <1361219360-29176-1-git-send-email-drjones@redhat.com> <20130219.005356.2288460992654639558.davem@davemloft.net> <51233FF502000078000BF4AE@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: "David Miller" , , , , , liuw@liuw.name To: "Jan Beulich" Return-path: In-Reply-To: <51233FF502000078000BF4AE@nat28.tlf.novell.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue, 19 Feb 2013 08:03:49 +0000 "Jan Beulich" wrote: > >>> On 19.02.13 at 06:53, David Miller wrote: > > From: Andrew Jones > > Date: Mon, 18 Feb 2013 21:29:20 +0100 > > > >> netbk_fatal_tx_err() calls xenvif_carrier_off(), which does > >> a xenvif_put(). As callers of netbk_fatal_tx_err should only > >> have one reference to the vif at this time, then the xenvif_put > >> in netbk_fatal_tx_err is one too many. > >> > >> Signed-off-by: Andrew Jones > > > > Applied. > > But this is wrong from all we can tell, we discussed this before > (Wei pointed to the discussion in an earlier reply). The core of > it is that the put here parallels the one in netbk_tx_err(), and > the one in xenvif_carrier_off() matches the get from > xenvif_connect() (which normally would be done on the path > coming through xenvif_disconnect()). I see the balance described by Ian in [1] now. Sorry that I missed that previous discussion and generated this noise. [1] http://marc.info/?l=xen-devel&m=136084174026977&w=2 drew > > And anyway - shouldn't changes to netback require an ack from > Ian? > > Jan >