From: David Miller <davem@davemloft.net>
To: fabio.estevam@freescale.com
Cc: Frank.Li@freescale.com, s.hauer@pengutronix.de,
jim_baxter@mentor.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: fec: Ensure that initialization is done prior to request_irq()
Date: Thu, 21 Feb 2013 15:27:24 -0500 (EST) [thread overview]
Message-ID: <20130221.152724.6508078801736235.davem@davemloft.net> (raw)
In-Reply-To: <1361474510-14286-1-git-send-email-fabio.estevam@freescale.com>
From: Fabio Estevam <fabio.estevam@freescale.com>
Date: Thu, 21 Feb 2013 16:21:50 -0300
> Currently request_irq() is called prior to fec_enet_init() and fec_ptp_init(),
> which causes the following crash on a mx53qsb:
>
> Unable to handle kernel NULL pointer dereference at virtual address 00000002
> pgd = 80004000
> [00000002] *pgd=00000000
> Internal error: Oops: 5 [#1] SMP ARM
> Modules linked in:
> CPU: 0 Not tainted (3.8.0-rc7-next-20130215+ #346)
> PC is at fec_enet_interrupt+0xd0/0x348
> LR is at fec_enet_interrupt+0xb8/0x348
> pc : [<80372b7c>] lr : [<80372b64>] psr: 60000193
> sp : df855c20 ip : df855c20 fp : df855c74
> r10: 00000516 r9 : 1c000000 r8 : 00000000
> r7 : 00000000 r6 : 00000000 r5 : 00000000 r4 : df9b7800
> r3 : df9b7df4 r2 : 00000000 r1 : 00000000 r0 : df9b7d34
>
> Ensure that such initialization functions are called prior to requesting the
> interrupts, so that all necessary the data structures are in place when the
> irqs occur.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Looks good, did you test this yourself or should we wait for others to
test it out?
next prev parent reply other threads:[~2013-02-21 20:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 19:21 [PATCH] net: fec: Ensure that initialization is done prior to request_irq() Fabio Estevam
2013-02-21 20:27 ` David Miller [this message]
2013-02-21 20:29 ` Fabio Estevam
2013-02-21 20:38 ` David Miller
2013-02-22 1:13 ` Jim Baxter
2013-02-22 1:44 ` Frank Li
2013-02-22 16:22 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130221.152724.6508078801736235.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Frank.Li@freescale.com \
--cc=fabio.estevam@freescale.com \
--cc=jim_baxter@mentor.com \
--cc=netdev@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).