From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: ycheng@google.com, ncardwell@google.com, edumazet@google.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] tcp: fix SYN-data space mis-accounting
Date: Fri, 22 Feb 2013 15:14:01 -0500 (EST) [thread overview]
Message-ID: <20130222.151401.47849208236481976.davem@davemloft.net> (raw)
In-Reply-To: <1361562058.3683.15.camel@edumazet-glaptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 22 Feb 2013 11:40:58 -0800
> On Fri, 2013-02-22 at 10:59 -0800, Yuchung Cheng wrote:
>> In fast open the sender unncessarily reduces the space available
>> for data in SYN by 12 bytes. This is because in the sender
>> incorrectly reserves space for TS option twice in tcp_send_syn_data():
>> tcp_mtu_to_mss() already accounts for TS option space. But it further
>> reserves MAX_TCP_OPTION_SPACE when computing the payload space.
>>
>> Signed-off-by: Yuchung Cheng <ycheng@google.com>
>> ---
>
> Acked-by: Eric Dumazet <edumazet@google.com>
Applied, and queue up for -stable, thanks everyone.
prev parent reply other threads:[~2013-02-22 20:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 18:59 [PATCH] tcp: fix SYN-data space mis-accounting Yuchung Cheng
2013-02-22 19:23 ` Neal Cardwell
2013-02-22 19:40 ` Eric Dumazet
2013-02-22 20:14 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130222.151401.47849208236481976.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).