* [PATCH] usb/net/asix_devices: Add USBNET HG20F9 ethernet dongle
@ 2013-02-26 4:17 Glen Turner
[not found] ` <1361852232.23197.4.camel-MFjF70HZCXOiAIzqYCf0vryL0Hf3YRqg06D/hhiQN/qHXe+LvDLADg@public.gmane.org>
2013-02-26 22:28 ` David Miller
0 siblings, 2 replies; 12+ messages in thread
From: Glen Turner @ 2013-02-26 4:17 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-usb, netdev, linux-kernel
This USB ethernet adapter was purchased in anodyne packaging
marked "USB2.0 to LAN" from the computer store adjacent to
linux.conf.au 2013 in Canberra (Australia). A web search
shows other recent purchasers in Lancaster (UK) and Seattle
(USA). Just like an emergent virus, our age of e-commerce and
airmail allows underdocumented hardware to spread around the
world instantly using the vector of ridiculously low prices.
Paige Thompson, infected via eBay, discovered that the HG20F9
is a copy of the Asix 88772B; many viruses copy the RNA of
other viruses. See Paige's work at
<https://github.com/paigeadele/HG20F9>.
This patch uses her discovery to update the restructured Asix
driver in the current kernel.
The spread of viruses is often accompanied by rumours. It is
rumoured that the HG20F9 has extensions to to provide gigabit
ethernet. This patch does not chase that chimera.
Just as some viruses inhabit seemingly-healthy cells, the
HG20F9 uses the Vendor ID 0x066b assigned to Linksys Inc.
For the present there is no clash of Product ID 0x20f9.
Signed-off-by: Glen Turner <gdt@gdt.id.au>
---
drivers/net/usb/asix_devices.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
index 7a6e758..649025d 100644
--- a/drivers/net/usb/asix_devices.c
+++ b/drivers/net/usb/asix_devices.c
@@ -883,6 +883,24 @@ static const struct driver_info ax88178_info = {
.tx_fixup = asix_tx_fixup,
};
+// USBLINK 20F9 "USB 2.0 LAN" USB ethernet adapter, typically found in
+// no-name packaging.
+// USB device strings are:
+// 1: Manufacturer: USBLINK
+// 2: Product: HG20F9 USB2.0
+// 3: Serial: 000003
+// Appears to be compatible with Asix 88772B.
+static const struct driver_info hg20f9_info = {
+ .description = "HG20F9 USB 2.0 Ethernet",
+ .bind = ax88772_bind,
+ .status = asix_status,
+ .link_reset = ax88772_link_reset,
+ .reset = ax88772_reset,
+ .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_LINK_INTR | FLAG_MULTI_PACKET,
+ .rx_fixup = asix_rx_fixup,
+ .tx_fixup = asix_tx_fixup,
+};
+
extern const struct driver_info ax88172a_info;
static const struct usb_device_id products [] = {
@@ -1022,6 +1040,12 @@ static const struct usb_device_id products [] = {
/* ASIX 88172a demo board */
USB_DEVICE(0x0b95, 0x172a),
.driver_info = (unsigned long) &ax88172a_info,
+}, {
+ // USBLINK HG20F9 "USB 2.0 LAN"
+ // Appears to have gazumped Linksys's manufacturer ID but
+ // doesn't (yet) conflict with any known Linksys product.
+ USB_DEVICE(0x066b, 0x20f9),
+ .driver_info = (unsigned long) &hg20f9_info,
},
{ }, // END
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 12+ messages in thread[parent not found: <1361852232.23197.4.camel-MFjF70HZCXOiAIzqYCf0vryL0Hf3YRqg06D/hhiQN/qHXe+LvDLADg@public.gmane.org>]
* Re: [PATCH] usb/net/asix_devices: Add USBNET HG20F9 ethernet dongle
[not found] ` <1361852232.23197.4.camel-MFjF70HZCXOiAIzqYCf0vryL0Hf3YRqg06D/hhiQN/qHXe+LvDLADg@public.gmane.org>
@ 2013-02-26 4:23 ` Greg Kroah-Hartman
[not found] ` <20130226042343.GA27766-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 12+ messages in thread
From: Greg Kroah-Hartman @ 2013-02-26 4:23 UTC (permalink / raw)
To: Glen Turner
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
On Tue, Feb 26, 2013 at 02:47:12PM +1030, Glen Turner wrote:
> This USB ethernet adapter was purchased in anodyne packaging
> marked "USB2.0 to LAN" from the computer store adjacent to
> linux.conf.au 2013 in Canberra (Australia). A web search
> shows other recent purchasers in Lancaster (UK) and Seattle
> (USA). Just like an emergent virus, our age of e-commerce and
> airmail allows underdocumented hardware to spread around the
> world instantly using the vector of ridiculously low prices.
>
> Paige Thompson, infected via eBay, discovered that the HG20F9
> is a copy of the Asix 88772B; many viruses copy the RNA of
> other viruses. See Paige's work at
> <https://github.com/paigeadele/HG20F9>.
> This patch uses her discovery to update the restructured Asix
> driver in the current kernel.
>
> The spread of viruses is often accompanied by rumours. It is
> rumoured that the HG20F9 has extensions to to provide gigabit
> ethernet. This patch does not chase that chimera.
>
> Just as some viruses inhabit seemingly-healthy cells, the
> HG20F9 uses the Vendor ID 0x066b assigned to Linksys Inc.
> For the present there is no clash of Product ID 0x20f9.
>
> Signed-off-by: Glen Turner <gdt-pRLresKaOUyHXe+LvDLADg@public.gmane.org>
That is the best "add a new device id" changelog entry I have _ever_
seen. Wonderful job:
Acked-by: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] usb/net/asix_devices: Add USBNET HG20F9 ethernet dongle
2013-02-26 4:17 [PATCH] usb/net/asix_devices: Add USBNET HG20F9 ethernet dongle Glen Turner
[not found] ` <1361852232.23197.4.camel-MFjF70HZCXOiAIzqYCf0vryL0Hf3YRqg06D/hhiQN/qHXe+LvDLADg@public.gmane.org>
@ 2013-02-26 22:28 ` David Miller
2013-02-26 22:29 ` David Miller
1 sibling, 1 reply; 12+ messages in thread
From: David Miller @ 2013-02-26 22:28 UTC (permalink / raw)
To: gdt; +Cc: gregkh, linux-usb, netdev, linux-kernel
From: Glen Turner <gdt@gdt.id.au>
Date: Tue, 26 Feb 2013 14:47:12 +1030
> This USB ethernet adapter was purchased in anodyne packaging
> marked "USB2.0 to LAN" from the computer store adjacent to
> linux.conf.au 2013 in Canberra (Australia). A web search
> shows other recent purchasers in Lancaster (UK) and Seattle
> (USA). Just like an emergent virus, our age of e-commerce and
> airmail allows underdocumented hardware to spread around the
> world instantly using the vector of ridiculously low prices.
>
> Paige Thompson, infected via eBay, discovered that the HG20F9
> is a copy of the Asix 88772B; many viruses copy the RNA of
> other viruses. See Paige's work at
> <https://github.com/paigeadele/HG20F9>.
> This patch uses her discovery to update the restructured Asix
> driver in the current kernel.
>
> The spread of viruses is often accompanied by rumours. It is
> rumoured that the HG20F9 has extensions to to provide gigabit
> ethernet. This patch does not chase that chimera.
>
> Just as some viruses inhabit seemingly-healthy cells, the
> HG20F9 uses the Vendor ID 0x066b assigned to Linksys Inc.
> For the present there is no clash of Product ID 0x20f9.
>
> Signed-off-by: Glen Turner <gdt@gdt.id.au>
Applied, thanks Glen.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] usb/net/asix_devices: Add USBNET HG20F9 ethernet dongle
2013-02-26 22:28 ` David Miller
@ 2013-02-26 22:29 ` David Miller
2013-02-27 9:07 ` Bjørn Mork
2013-02-27 14:32 ` [PATCHv2] " Glen Turner
0 siblings, 2 replies; 12+ messages in thread
From: David Miller @ 2013-02-26 22:29 UTC (permalink / raw)
To: gdt; +Cc: gregkh, linux-usb, netdev, linux-kernel
From: David Miller <davem@davemloft.net>
Date: Tue, 26 Feb 2013 17:28:56 -0500 (EST)
> Applied, thanks Glen.
Actually, I had to revert, this doesn't even compile against
current sources:
CC [M] drivers/net/usb/asix_devices.o
drivers/net/usb/asix_devices.c:941:14: error: ‘asix_rx_fixup’ undeclared here (not in a function)
make[1]: *** [drivers/net/usb/asix_devices.o] Error 1
make: *** [drivers/net/usb/asix_devices.o] Error 2
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] usb/net/asix_devices: Add USBNET HG20F9 ethernet dongle
2013-02-26 22:29 ` David Miller
@ 2013-02-27 9:07 ` Bjørn Mork
2013-02-27 14:32 ` [PATCHv2] " Glen Turner
1 sibling, 0 replies; 12+ messages in thread
From: Bjørn Mork @ 2013-02-27 9:07 UTC (permalink / raw)
To: gdt; +Cc: gregkh, linux-usb, netdev, linux-kernel
David Miller <davem@davemloft.net> writes:
>> Applied, thanks Glen.
>
> Actually, I had to revert, this doesn't even compile against
> current sources:
>
> CC [M] drivers/net/usb/asix_devices.o
> drivers/net/usb/asix_devices.c:941:14: error: ‘asix_rx_fixup’ undeclared here (not in a function)
> make[1]: *** [drivers/net/usb/asix_devices.o] Error 1
> make: *** [drivers/net/usb/asix_devices.o] Error 2
I believe this patch will make checkpatch cry
ERROR: do not use C99 // comments
as well. It would be nice if that was fixed as well before resending.
But please keep the commit message :)
Bjørn
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCHv2] usb/net/asix_devices: Add USBNET HG20F9 ethernet dongle
2013-02-26 22:29 ` David Miller
2013-02-27 9:07 ` Bjørn Mork
@ 2013-02-27 14:32 ` Glen Turner
2013-02-27 18:11 ` David Miller
1 sibling, 1 reply; 12+ messages in thread
From: Glen Turner @ 2013-02-27 14:32 UTC (permalink / raw)
To: David Miller; +Cc: gregkh, linux-usb, netdev, linux-kernel
This USB ethernet adapter was purchased in anodyne packaging
from the computer store adjacent to linux.conf.au 2013 in
Canberra (Australia). A web search shows other recent
purchasers in Lancaster (UK) and Seattle (USA). Just like an
emergent virus, our age of e-commerce and airmail allows
underdocumented hardware to spread around the world instantly
using the vector of ridiculously low prices.
Paige Thompson, infected via eBay, discovered that the HG20F9
is a copy of the Asix 88772B; many viruses copy the RNA of
other viruses. See Paige's work at
<https://github.com/paigeadele/HG20F9>.
This patch uses her discovery to update the restructured Asix
driver in the current kernel.
Just as some viruses inhabit seemingly-healthy cells, the
HG20F9 uses the Vendor ID 0x066b assigned to Linksys Inc.
For the present there is no clash of Product ID 0x20f9.
Signed-off-by: Glen Turner <gdt@gdt.id.au>
---
David,
My apologies for the patch failing to compile. I worked off Linus' GIT tree
from a week ago, which I now realise was ignorant. Today I downloaded
<git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git>,
modified the patch to suit, compiled with a distributor's .config (ten hours
on my EeePC 901), and re-tested against a range of switches and traffic.
Thanks to Bjørn Mork for the heads-up about comment coding style. I had
copied the style used throughout asix_devices.c but one never knows where
being on the bad side of an automated tool can lead, now that the creator
of the Daleks can no longer protect us from robots with rigid notions
of the acceptable and the exterminatable.
-glen
drivers/net/usb/asix_devices.c | 31 +++++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
index 2205dbc..7097534 100644
--- a/drivers/net/usb/asix_devices.c
+++ b/drivers/net/usb/asix_devices.c
@@ -924,6 +924,29 @@ static const struct driver_info ax88178_info = {
.tx_fixup = asix_tx_fixup,
};
+/*
+ * USBLINK 20F9 "USB 2.0 LAN" USB ethernet adapter, typically found in
+ * no-name packaging.
+ * USB device strings are:
+ * 1: Manufacturer: USBLINK
+ * 2: Product: HG20F9 USB2.0
+ * 3: Serial: 000003
+ * Appears to be compatible with Asix 88772B.
+ */
+static const struct driver_info hg20f9_info = {
+ .description = "HG20F9 USB 2.0 Ethernet",
+ .bind = ax88772_bind,
+ .unbind = ax88772_unbind,
+ .status = asix_status,
+ .link_reset = ax88772_link_reset,
+ .reset = ax88772_reset,
+ .flags = FLAG_ETHER | FLAG_FRAMING_AX | FLAG_LINK_INTR |
+ FLAG_MULTI_PACKET,
+ .rx_fixup = asix_rx_fixup_common,
+ .tx_fixup = asix_tx_fixup,
+ .data = FLAG_EEPROM_MAC,
+};
+
extern const struct driver_info ax88172a_info;
static const struct usb_device_id products [] = {
@@ -1063,6 +1086,14 @@ static const struct usb_device_id products [] = {
/* ASIX 88172a demo board */
USB_DEVICE(0x0b95, 0x172a),
.driver_info = (unsigned long) &ax88172a_info,
+}, {
+ /*
+ * USBLINK HG20F9 "USB 2.0 LAN"
+ * Appears to have gazumped Linksys's manufacturer ID but
+ * doesn't (yet) conflict with any known Linksys product.
+ */
+ USB_DEVICE(0x066b, 0x20f9),
+ .driver_info = (unsigned long) &hg20f9_info,
},
{ }, // END
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCHv2] usb/net/asix_devices: Add USBNET HG20F9 ethernet dongle
2013-02-27 14:32 ` [PATCHv2] " Glen Turner
@ 2013-02-27 18:11 ` David Miller
0 siblings, 0 replies; 12+ messages in thread
From: David Miller @ 2013-02-27 18:11 UTC (permalink / raw)
To: gdt; +Cc: gregkh, linux-usb, netdev, linux-kernel
From: Glen Turner <gdt@gdt.id.au>
Date: Thu, 28 Feb 2013 01:02:36 +1030
> This USB ethernet adapter was purchased in anodyne packaging
> from the computer store adjacent to linux.conf.au 2013 in
> Canberra (Australia). A web search shows other recent
> purchasers in Lancaster (UK) and Seattle (USA). Just like an
> emergent virus, our age of e-commerce and airmail allows
> underdocumented hardware to spread around the world instantly
> using the vector of ridiculously low prices.
>
> Paige Thompson, infected via eBay, discovered that the HG20F9
> is a copy of the Asix 88772B; many viruses copy the RNA of
> other viruses. See Paige's work at
> <https://github.com/paigeadele/HG20F9>.
> This patch uses her discovery to update the restructured Asix
> driver in the current kernel.
>
> Just as some viruses inhabit seemingly-healthy cells, the
> HG20F9 uses the Vendor ID 0x066b assigned to Linksys Inc.
> For the present there is no clash of Product ID 0x20f9.
>
> Signed-off-by: Glen Turner <gdt@gdt.id.au>
Applied, thanks.
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2013-02-27 18:11 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-26 4:17 [PATCH] usb/net/asix_devices: Add USBNET HG20F9 ethernet dongle Glen Turner
[not found] ` <1361852232.23197.4.camel-MFjF70HZCXOiAIzqYCf0vryL0Hf3YRqg06D/hhiQN/qHXe+LvDLADg@public.gmane.org>
2013-02-26 4:23 ` Greg Kroah-Hartman
[not found] ` <20130226042343.GA27766-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2013-02-26 4:45 ` David Miller
[not found] ` <20130225.234529.1601978289377551611.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2013-02-26 5:03 ` Greg KH
2013-02-26 5:10 ` David Miller
2013-02-26 5:20 ` Greg KH
2013-02-26 21:09 ` Richard Ash
2013-02-26 22:28 ` David Miller
2013-02-26 22:29 ` David Miller
2013-02-27 9:07 ` Bjørn Mork
2013-02-27 14:32 ` [PATCHv2] " Glen Turner
2013-02-27 18:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).