netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: cdc_ncm: tag Huawei devices (e.g. E5331) with FLAG_WWAN
@ 2013-02-27 13:08 Bjørn Mork
       [not found] ` <1361970538-24451-1-git-send-email-bjorn-yOkvZcmFvRU@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Bjørn Mork @ 2013-02-27 13:08 UTC (permalink / raw)
  To: netdev; +Cc: linux-usb, Alexey Orishko, Bjørn Mork

Tag all Huawei NCM devices as WWAN modems, as we don't know of any which
are not.  This is necessary for userspace clients to know that the device
requires further setup on e.g. an AT-capable serial ports before
connectivity is available.

Signed-off-by: Bjørn Mork <bjorn@mork.no>
---
 drivers/net/usb/cdc_ncm.c |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/net/usb/cdc_ncm.c b/drivers/net/usb/cdc_ncm.c
index 4a8c25a..61b74a2 100644
--- a/drivers/net/usb/cdc_ncm.c
+++ b/drivers/net/usb/cdc_ncm.c
@@ -1213,6 +1213,14 @@ static const struct usb_device_id cdc_devs[] = {
 	  .driver_info = (unsigned long) &wwan_info,
 	},
 
+	/* tag Huawei devices as wwan */
+	{ USB_VENDOR_AND_INTERFACE_INFO(0x12d1,
+					USB_CLASS_COMM,
+					USB_CDC_SUBCLASS_NCM,
+					USB_CDC_PROTO_NONE),
+	  .driver_info = (unsigned long)&wwan_info,
+	},
+
 	/* Huawei NCM devices disguised as vendor specific */
 	{ USB_VENDOR_AND_INTERFACE_INFO(0x12d1, 0xff, 0x02, 0x16),
 	  .driver_info = (unsigned long)&wwan_info,
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: cdc_ncm: tag Huawei devices (e.g. E5331) with FLAG_WWAN
       [not found] ` <1361970538-24451-1-git-send-email-bjorn-yOkvZcmFvRU@public.gmane.org>
@ 2013-02-27 18:12   ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-02-27 18:12 UTC (permalink / raw)
  To: bjorn-yOkvZcmFvRU
  Cc: netdev-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA,
	alexey.orishko-0IS4wlFg1OjSUeElwK9/Pw

From: Bjørn Mork <bjorn-yOkvZcmFvRU@public.gmane.org>
Date: Wed, 27 Feb 2013 14:08:58 +0100

> Tag all Huawei NCM devices as WWAN modems, as we don't know of any which
> are not.  This is necessary for userspace clients to know that the device
> requires further setup on e.g. an AT-capable serial ports before
> connectivity is available.
> 
> Signed-off-by: Bjørn Mork <bjorn-yOkvZcmFvRU@public.gmane.org>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-02-27 18:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-27 13:08 [PATCH] net: cdc_ncm: tag Huawei devices (e.g. E5331) with FLAG_WWAN Bjørn Mork
     [not found] ` <1361970538-24451-1-git-send-email-bjorn-yOkvZcmFvRU@public.gmane.org>
2013-02-27 18:12   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).