From: David Miller <davem@davemloft.net>
To: zajec5@gmail.com
Cc: hauke@hauke-m.de, netdev@vger.kernel.org
Subject: Re: [PATCH] bgmac: omit the fcs
Date: Thu, 28 Feb 2013 14:21:42 -0500 (EST) [thread overview]
Message-ID: <20130228.142142.242861205295035084.davem@davemloft.net> (raw)
In-Reply-To: <CACna6rw6MR3agrDvz0+X7ne6uSNQN0tpZupeM5c-6xy5-pvv2Q@mail.gmail.com>
From: Rafał Miłecki <zajec5@gmail.com>
Date: Thu, 28 Feb 2013 18:57:03 +0100
> 2013/2/28 Hauke Mehrtens <hauke@hauke-m.de>:
>> Do not include the frame check sequence when adding the skb to
>> netif_receive_skb(). This causes problems when this interface was
>> bridged to a wifi ap and a big package should be forwarded from this
>> Ethernet driver through a bride to the wifi client.
>
> Is this a real fix?
>
> Don't get me wrong, but it sounds a little like a workaround for some
> issue in another network layer ;)
FCS should never be included in the SKB unless a specific debugging
configuration knob has enabled it.
Having the FCS there will screw up things like device provided partial
checksums (CHECKSUM_PARTIAL), which operate over the entire contents
of the packet starting at a particular offset, so if the FCS is there
we'll include it.
This change is therefore about as correct as can possibly be.
next prev parent reply other threads:[~2013-02-28 19:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 17:16 [PATCH] bgmac: omit the fcs Hauke Mehrtens
2013-02-28 17:57 ` Rafał Miłecki
2013-02-28 18:13 ` Hauke Mehrtens
2013-02-28 19:21 ` David Miller [this message]
2013-02-28 19:25 ` Rafał Miłecki
2013-02-28 22:16 ` Eric Dumazet
2013-02-28 20:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130228.142142.242861205295035084.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hauke@hauke-m.de \
--cc=netdev@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).