Re: [PATCH v2 net-next] ipv[4|6]: correct dropwatch false positive in local_deliver_finish

[David Miller <davem@davemloft.net>]

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 01 Mar 2013 09:56:44 -0800

> On Fri, 2013-03-01 at 12:44 -0500, Neil Horman wrote:
>> I had a report recently of a user trying to use dropwatch to localise some frame
>> loss, and they were getting false positives.  Turned out they were using a user
>> space SCTP stack that used raw sockets to grab frames.  When we don't have a
>> registered protocol for a given packet, we record it as a drop, even if a raw
>> socket receieves the frame.  We should only record the drop in the event a raw
>> socket doesnt exist to receive the frames
>> 
>> Tested by the reported successfully
>> 
>> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
>> Reported-by: William Reich <reich@ulticom.com>
>> Tested-by: William Reich <reich@ulticom.com>
>> CC: "David S. Miller" <davem@davemloft.net>
>> CC: William Reich <reich@ulticom.com>
>> CC: eric.dumazet@gmail.com
>> ---
>>  net/ipv4/ip_input.c  | 6 ++++--
>>  net/ipv6/ip6_input.c | 6 ++++--
>>  2 files changed, 8 insertions(+), 4 deletions(-)
> 
> Thanks !
> 
> Acked-by: Eric Dumazet <edumazet@google.com>

This seems like a reasonable bug fix so I'm going to apply this to
'net', thanks everyone.