netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [patch] sctp: use the passed in gfp flags instead GFP_KERNEL
@ 2013-03-01  5:27 Dan Carpenter
  2013-03-01 14:35 ` Neil Horman
  2013-03-01 21:00 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2013-03-01  5:27 UTC (permalink / raw)
  To: Vlad Yasevich
  Cc: Sridhar Samudrala, Neil Horman, David S. Miller, linux-sctp,
	netdev, kernel-janitors

This patch doesn't change how the code works because in the current
kernel gfp is always GFP_KERNEL.  But gfp was obviously intended
instead of GFP_KERNEL.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/net/sctp/endpointola.c b/net/sctp/endpointola.c
index 2b3ef03..12ed45d 100644
--- a/net/sctp/endpointola.c
+++ b/net/sctp/endpointola.c
@@ -155,7 +155,7 @@ static struct sctp_endpoint *sctp_endpoint_init(struct sctp_endpoint *ep,
 
 	/* SCTP-AUTH extensions*/
 	INIT_LIST_HEAD(&ep->endpoint_shared_keys);
-	null_key = sctp_auth_shkey_create(0, GFP_KERNEL);
+	null_key = sctp_auth_shkey_create(0, gfp);
 	if (!null_key)
 		goto nomem;
 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [patch] sctp: use the passed in gfp flags instead GFP_KERNEL
  2013-03-01  5:27 [patch] sctp: use the passed in gfp flags instead GFP_KERNEL Dan Carpenter
@ 2013-03-01 14:35 ` Neil Horman
  2013-03-01 21:00 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Neil Horman @ 2013-03-01 14:35 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Vlad Yasevich, Sridhar Samudrala, David S. Miller, linux-sctp,
	netdev, kernel-janitors

On Fri, Mar 01, 2013 at 08:27:43AM +0300, Dan Carpenter wrote:
> This patch doesn't change how the code works because in the current
> kernel gfp is always GFP_KERNEL.  But gfp was obviously intended
> instead of GFP_KERNEL.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/net/sctp/endpointola.c b/net/sctp/endpointola.c
> index 2b3ef03..12ed45d 100644
> --- a/net/sctp/endpointola.c
> +++ b/net/sctp/endpointola.c
> @@ -155,7 +155,7 @@ static struct sctp_endpoint *sctp_endpoint_init(struct sctp_endpoint *ep,
>  
>  	/* SCTP-AUTH extensions*/
>  	INIT_LIST_HEAD(&ep->endpoint_shared_keys);
> -	null_key = sctp_auth_shkey_create(0, GFP_KERNEL);
> +	null_key = sctp_auth_shkey_create(0, gfp);
>  	if (!null_key)
>  		goto nomem;
>  
> 
Acked-by: Neil Horman <nhorman@tuxdriver.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [patch] sctp: use the passed in gfp flags instead GFP_KERNEL
  2013-03-01  5:27 [patch] sctp: use the passed in gfp flags instead GFP_KERNEL Dan Carpenter
  2013-03-01 14:35 ` Neil Horman
@ 2013-03-01 21:00 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-03-01 21:00 UTC (permalink / raw)
  To: dan.carpenter
  Cc: vyasevich, sri, nhorman, linux-sctp, netdev, kernel-janitors

From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 1 Mar 2013 08:27:43 +0300

> This patch doesn't change how the code works because in the current
> kernel gfp is always GFP_KERNEL.  But gfp was obviously intended
> instead of GFP_KERNEL.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-03-01 21:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-01  5:27 [patch] sctp: use the passed in gfp flags instead GFP_KERNEL Dan Carpenter
2013-03-01 14:35 ` Neil Horman
2013-03-01 21:00 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).