From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [PATCH v2 net-next] ipv[4|6]: correct dropwatch false positive in local_deliver_finish Date: Fri, 1 Mar 2013 16:05:45 -0500 Message-ID: <20130301210545.GD1523@hmsreliant.think-freely.org> References: <1362159848-8530-1-git-send-email-nhorman@tuxdriver.com> <1362160604.15793.57.camel@edumazet-glaptop> <20130301.155709.1482599990846126981.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, reich@ulticom.com To: David Miller Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:59938 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751320Ab3CAVF4 (ORCPT ); Fri, 1 Mar 2013 16:05:56 -0500 Content-Disposition: inline In-Reply-To: <20130301.155709.1482599990846126981.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Mar 01, 2013 at 03:57:09PM -0500, David Miller wrote: > From: Eric Dumazet > Date: Fri, 01 Mar 2013 09:56:44 -0800 > > > On Fri, 2013-03-01 at 12:44 -0500, Neil Horman wrote: > >> I had a report recently of a user trying to use dropwatch to localise some frame > >> loss, and they were getting false positives. Turned out they were using a user > >> space SCTP stack that used raw sockets to grab frames. When we don't have a > >> registered protocol for a given packet, we record it as a drop, even if a raw > >> socket receieves the frame. We should only record the drop in the event a raw > >> socket doesnt exist to receive the frames > >> > >> Tested by the reported successfully > >> > >> Signed-off-by: Neil Horman > >> Reported-by: William Reich > >> Tested-by: William Reich > >> CC: "David S. Miller" > >> CC: William Reich > >> CC: eric.dumazet@gmail.com > >> --- > >> net/ipv4/ip_input.c | 6 ++++-- > >> net/ipv6/ip6_input.c | 6 ++++-- > >> 2 files changed, 8 insertions(+), 4 deletions(-) > > > > Thanks ! > > > > Acked-by: Eric Dumazet > > This seems like a reasonable bug fix so I'm going to apply this to > 'net', thanks everyone. > Copy that, thanks Dave! Neil