From: Francois Romieu <romieu@fr.zoreil.com>
To: Dave Jones <davej@redhat.com>
Cc: netdev@vger.kernel.org, Bruce Allan <bruce.w.allan@intel.com>
Subject: Re: e1000e disabling already-disabled device
Date: Mon, 4 Mar 2013 00:36:24 +0100 [thread overview]
Message-ID: <20130303233624.GA28784@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <20130303162124.GA31371@redhat.com>
Dave Jones <davej@redhat.com> :
[...]
> ------------[ cut here ]------------
> WARNING: at drivers/pci/pci.c:1397 pci_disable_device+0x90/0xa0()
> Hardware name: 2356JK8
> Device e1000e
> disabling already-disabled device
> Modules linked in:
> dm_crypt arc4 iwldvm mac80211 ipv6 iTCO_wdt xfs iTCO_vendor_support libcrc32c coretemp kvm_intel kvm crc32c_intel ghash_clmulni_intel microcode snd_hda_codec_hdmi snd_hda_codec_realtek btusb bluetooth iwlwifi pcspkr snd_hda_intel cfg80211 snd_hda_codec snd_pcm lpc_ich mfd_core e1000e snd_page_alloc ptp pps_core thinkpad_acpi hwmon led_class rfkill wmi nfsd auth_rpcgss nfs_acl lockd sunrpc i915 i2c_algo_bit drm_kms_helper drm i2c_core video
> Pid: 19776, comm: kworker/u:11 Not tainted 3.8.0+ #6
> Call Trace:
> [<ffffffff81049855>] warn_slowpath_common+0x75/0xa0
> [<ffffffff81049936>] warn_slowpath_fmt+0x46/0x50
> [<ffffffff81359760>] pci_disable_device+0x90/0xa0
> [<ffffffffa0251092>] __e1000_shutdown+0x262/0x8a0 [e1000e]
> [<ffffffffa0251743>] e1000_suspend+0x23/0x50 [e1000e]
> [<ffffffff816284b9>] ? sub_preempt_count+0x79/0xd0
> [<ffffffff8135bd97>] pci_pm_suspend+0x77/0x140
> [<ffffffff8135bd20>] ? pci_pm_poweroff+0xf0/0xf0
> [<ffffffff8140c678>] dpm_run_callback+0x58/0x90
> [<ffffffff8140c79d>] __device_suspend+0xed/0x280
> [<ffffffff8140d1ef>] async_suspend+0x1f/0xa0
Could it be that runtime power management is also enabled, you have no
link and thus end running both runtime_suspend and suspend at different
times ?
I wonder why the driver disables the PCI device here btw.
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index a177b8b..5c643c6 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -5986,8 +5986,6 @@ static int __e1000_shutdown(struct pci_dev *pdev, bool *enable_wake,
*/
e1000e_release_hw_control(adapter);
- pci_disable_device(pdev);
-
return 0;
}
---
Ueimor
next prev parent reply other threads:[~2013-03-03 23:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-03 16:21 e1000e disabling already-disabled device Dave Jones
2013-03-03 23:36 ` Francois Romieu [this message]
2013-03-05 2:11 ` Allan, Bruce W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130303233624.GA28784@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=bruce.w.allan@intel.com \
--cc=davej@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox