* [PATCH v2] CAIF: fix sparse warning for caif_usb
@ 2013-03-04 6:52 Silviu-Mihai Popescu
2013-03-04 7:00 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Silviu-Mihai Popescu @ 2013-03-04 6:52 UTC (permalink / raw)
To: netdev; +Cc: sjur.brandeland, davem, linux-kernel
This fixes the following sparse warning:
net/caif/caif_usb.c:84:16: warning: symbol 'cfusbl_create' was not
declared. Should it be static?
Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
---
net/caif/caif_usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/caif/caif_usb.c b/net/caif/caif_usb.c
index 3ebc8cb..1c6ded9 100644
--- a/net/caif/caif_usb.c
+++ b/net/caif/caif_usb.c
@@ -81,8 +81,8 @@ static void cfusbl_ctrlcmd(struct cflayer *layr, enum caif_ctrlcmd ctrl,
layr->up->ctrlcmd(layr->up, ctrl, layr->id);
}
-struct cflayer *cfusbl_create(int phyid, u8 ethaddr[ETH_ALEN],
- u8 braddr[ETH_ALEN])
+static struct cflayer *cfusbl_create(int phyid, u8 ethaddr[ETH_ALEN],
+ u8 braddr[ETH_ALEN])
{
struct cfusbl *this = kmalloc(sizeof(struct cfusbl), GFP_ATOMIC);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] CAIF: fix sparse warning for caif_usb
2013-03-04 6:52 [PATCH v2] CAIF: fix sparse warning for caif_usb Silviu-Mihai Popescu
@ 2013-03-04 7:00 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2013-03-04 7:00 UTC (permalink / raw)
To: silviupopescu1990; +Cc: netdev, sjur.brandeland, linux-kernel
From: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
Date: Mon, 4 Mar 2013 08:52:00 +0200
> This fixes the following sparse warning:
> net/caif/caif_usb.c:84:16: warning: symbol 'cfusbl_create' was not
> declared. Should it be static?
>
> Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
> ---
> net/caif/caif_usb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/caif/caif_usb.c b/net/caif/caif_usb.c
> index 3ebc8cb..1c6ded9 100644
> --- a/net/caif/caif_usb.c
> +++ b/net/caif/caif_usb.c
> @@ -81,8 +81,8 @@ static void cfusbl_ctrlcmd(struct cflayer *layr, enum caif_ctrlcmd ctrl,
> layr->up->ctrlcmd(layr->up, ctrl, layr->id);
> }
>
> -struct cflayer *cfusbl_create(int phyid, u8 ethaddr[ETH_ALEN],
> - u8 braddr[ETH_ALEN])
> +static struct cflayer *cfusbl_create(int phyid, u8 ethaddr[ETH_ALEN],
> + u8 braddr[ETH_ALEN])
Nope, that indentation isn't correct, is should be:
static struct cflayer *cfusbl_create(int phyid, u8 ethaddr[ETH_ALEN],
u8 braddr[ETH_ALEN])
Read my email, I said that the first character on the second line
must line up with the first column after the openning parenthesis
of the first line.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-04 7:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-04 6:52 [PATCH v2] CAIF: fix sparse warning for caif_usb Silviu-Mihai Popescu
2013-03-04 7:00 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).