From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH] net: netfilter: nfnetlink: Fixed warning for nfnl_get_lock Date: Mon, 4 Mar 2013 22:05:51 +0100 Message-ID: <20130304210551.GA22306@pd.tnic> References: <1362426192-2921-1-git-send-email-gheorghiuandru@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Pablo Neira Ayuso , Patrick McHardy , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Alexandru Gheorghiu Return-path: Received: from mail.skyhub.de ([78.46.96.112]:38600 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758751Ab3CDVGJ (ORCPT ); Mon, 4 Mar 2013 16:06:09 -0500 Content-Disposition: inline In-Reply-To: <1362426192-2921-1-git-send-email-gheorghiuandru@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Mar 04, 2013 at 09:43:11PM +0200, Alexandru Gheorghiu wrote: > Removed unused function nfnl_get_lock which fixed the following warni= ng: > net/netfilter/nfnetlink.c:65:22: warning: =E2=80=98nfnl_get_lock=E2=80= =99 defined but not used [-Wunused-function] >=20 > Signed-off-by: Alexandru Gheorghiu > --- > net/netfilter/nfnetlink.c | 5 ----- > 1 file changed, 5 deletions(-) >=20 > diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c > index d578ec2..44aa0a7 100644 > --- a/net/netfilter/nfnetlink.c > +++ b/net/netfilter/nfnetlink.c > @@ -62,11 +62,6 @@ void nfnl_unlock(__u8 subsys_id) > } > EXPORT_SYMBOL_GPL(nfnl_unlock); >=20 > -static struct mutex *nfnl_get_lock(__u8 subsys_id) > -{ > - return &table[subsys_id].mutex; > -} > - I see the same warning here, gcc (Debian 4.7.2-5) 4.7.2. Actually this function *is* used a bit further in the same file in nfnetlink_rcv_msg(). But gcc complains for some reason of which I don't even have the slightest idea. However, if you declare the above function "static inline..." the warning is gone. --=20 Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --