netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: silviupopescu1990@gmail.com, netdev@vger.kernel.org,
	sjur.brandeland@stericsson.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] CAIF: fix indentation for function arguments
Date: Wed, 06 Mar 2013 19:35:11 -0500 (EST)	[thread overview]
Message-ID: <20130306.193511.1262845535253279851.davem@davemloft.net> (raw)
In-Reply-To: <1362614837.2093.30.camel@joe-AO722>

From: Joe Perches <joe@perches.com>
Date: Wed, 06 Mar 2013 16:07:17 -0800

> On Wed, 2013-03-06 at 23:48 +0200, Silviu-Mihai Popescu wrote:
>> This lines up function arguments on second and subsequent lines at the
>> first column after the openning parenthesis of the first line.
> []
>> diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c
> []
>> @@ -301,10 +301,10 @@ static void dev_flowctrl(struct net_device *dev, int on)
>>  }
>>  
>>  void caif_enroll_dev(struct net_device *dev, struct caif_dev_common *caifdev,
>> -			struct cflayer *link_support, int head_room,
>> -			struct cflayer **layer, int (**rcv_func)(
>> -				struct sk_buff *, struct net_device *,
>> -				struct packet_type *, struct net_device *))
>> +		     struct cflayer *link_support, int head_room,
>> +		     struct cflayer **layer, int (**rcv_func)(
>> +		     struct sk_buff *, struct net_device *,
>> +		     struct packet_type *, struct net_device *))
> 
> This makes it seem that caif_enroll_dev takes more args.
> 
> I think this style is better (aligned to appropriate open paren)
> 
> void caif_enroll_dev(struct net_device *dev, struct caif_dev_common *caifdev,
> 		     struct cflayer *link_support, int head_room,
> 		     struct cflayer **layer,
> 		     int (**rcv_func)(struct sk_buff *, struct net_device *,
> 				      struct packet_type *, struct net_device *))

Agreed.

      reply	other threads:[~2013-03-07  0:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-06 21:48 [PATCH] CAIF: fix indentation for function arguments Silviu-Mihai Popescu
2013-03-06 22:36 ` Sjur Brændeland
2013-03-07  0:07 ` Joe Perches
2013-03-07  0:35   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130306.193511.1262845535253279851.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=silviupopescu1990@gmail.com \
    --cc=sjur.brandeland@stericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).