From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] CAIF: fix indentation for function arguments Date: Wed, 06 Mar 2013 19:35:11 -0500 (EST) Message-ID: <20130306.193511.1262845535253279851.davem@davemloft.net> References: <1362606521-16848-1-git-send-email-silviupopescu1990@gmail.com> <1362614837.2093.30.camel@joe-AO722> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: silviupopescu1990@gmail.com, netdev@vger.kernel.org, sjur.brandeland@stericsson.com, linux-kernel@vger.kernel.org To: joe@perches.com Return-path: In-Reply-To: <1362614837.2093.30.camel@joe-AO722> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Joe Perches Date: Wed, 06 Mar 2013 16:07:17 -0800 > On Wed, 2013-03-06 at 23:48 +0200, Silviu-Mihai Popescu wrote: >> This lines up function arguments on second and subsequent lines at the >> first column after the openning parenthesis of the first line. > [] >> diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c > [] >> @@ -301,10 +301,10 @@ static void dev_flowctrl(struct net_device *dev, int on) >> } >> >> void caif_enroll_dev(struct net_device *dev, struct caif_dev_common *caifdev, >> - struct cflayer *link_support, int head_room, >> - struct cflayer **layer, int (**rcv_func)( >> - struct sk_buff *, struct net_device *, >> - struct packet_type *, struct net_device *)) >> + struct cflayer *link_support, int head_room, >> + struct cflayer **layer, int (**rcv_func)( >> + struct sk_buff *, struct net_device *, >> + struct packet_type *, struct net_device *)) > > This makes it seem that caif_enroll_dev takes more args. > > I think this style is better (aligned to appropriate open paren) > > void caif_enroll_dev(struct net_device *dev, struct caif_dev_common *caifdev, > struct cflayer *link_support, int head_room, > struct cflayer **layer, > int (**rcv_func)(struct sk_buff *, struct net_device *, > struct packet_type *, struct net_device *)) Agreed.