Re: [PATCH] team: unsyc the devices addresses when port is removed

[Jiri Pirko <jiri@resnulli.us>]

Thu, Mar 07, 2013 at 06:59:25PM CET, vyasevic@redhat.com wrote:
>When a team port is removed, unsync all devices addresses that may have
>been synched to the port devices.


This is looking good to me. Thanks for spotting this bug.

Acked-by: Jiri Pirko <jiri@resnulli.us>

>
>CC: Jiri Pirko <jiri@resnulli.us>
>Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
>---
> drivers/net/team/team.c |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/net/team/team.c b/drivers/net/team/team.c
>index 05c5efe..bf34192 100644
>--- a/drivers/net/team/team.c
>+++ b/drivers/net/team/team.c
>@@ -1138,6 +1138,8 @@ static int team_port_del(struct team *team, struct net_device *port_dev)
> 	netdev_upper_dev_unlink(port_dev, dev);
> 	team_port_disable_netpoll(port);
> 	vlan_vids_del_by_dev(port_dev, dev);
>+	dev_uc_unsync(port_dev, dev);
>+	dev_mc_unsync(port_dev, dev);
> 	dev_close(port_dev);
> 	team_port_leave(team, port);
> 
>-- 
>1.7.7.6
>